[PATCH] OMAP2+: Fix random config build break with !ARM_CPU_SUSPEND

Subsystems: arm port, omap2+ support, the rest

STALE5144d

2 messages, 2 authors, 2012-08-07 · open the first message on its own page

[PATCH] OMAP2+: Fix random config build break with !ARM_CPU_SUSPEND

From: Santosh Shilimkar <hidden>
Date: 2012-07-13 10:45:07

The random config builds with PM and !ARM_CPU_SUSPEND breaks with below
error on omap2plus_defconfig.

arch/arm/mach-omap2/sleep44xx.S:323: undefined reference to `cpu_resume'
arch/arm/mach-omap2/omap-mpuss-lowpower.c:278: undefined reference to `cpu_suspend'

This is because recently merged OMAP5 platform shares the common files
with OMAP4 but doesn't select ARM_CPU_SUSPEND. Without the ARM_CPU_SUSPEND
the sleep code is meaningless.

Fix the same by adding ARM_CPU_SUSPEND for OMAP5. The suggestion came from
Russell King in an off-list discussion.

Cc: Russell King <redacted>
Cc: Kevin Hilman <redacted>
Reported-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Santosh Shilimkar <redacted>
---
Applies against linux-omap master at commit cb07e339457.

 arch/arm/mach-omap2/Kconfig |    1 +
 1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
index 2c73f38..976050d 100644
--- a/arch/arm/mach-omap2/Kconfig
+++ b/arch/arm/mach-omap2/Kconfig
@@ -68,6 +68,7 @@ config SOC_OMAP5
 	select CPU_V7
 	select ARM_GIC
 	select HAVE_SMP
+	select ARM_CPU_SUSPEND if PM
 
 comment "OMAP Core Type"
 	depends on ARCH_OMAP2
-- 
1.7.9.5

[PATCH] OMAP2+: Fix random config build break with !ARM_CPU_SUSPEND

From: tony@atomide.com (Tony Lindgren)
Date: 2012-08-07 07:23:01

* Santosh Shilimkar [off-list ref] [120713 03:50]:
The random config builds with PM and !ARM_CPU_SUSPEND breaks with below
error on omap2plus_defconfig.

arch/arm/mach-omap2/sleep44xx.S:323: undefined reference to `cpu_resume'
arch/arm/mach-omap2/omap-mpuss-lowpower.c:278: undefined reference to `cpu_suspend'

This is because recently merged OMAP5 platform shares the common files
with OMAP4 but doesn't select ARM_CPU_SUSPEND. Without the ARM_CPU_SUSPEND
the sleep code is meaningless.

Fix the same by adding ARM_CPU_SUSPEND for OMAP5. The suggestion came from
Russell King in an off-list discussion.
Thanks applying into fixes.

Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help