@@ -256,7 +256,7 @@ int __init mx27_clocks_init(unsigned long fref)clk_register_clkdev(clk[gpio_ipg_gate],"gpio",NULL);clk_register_clkdev(clk[brom_ahb_gate],"brom",NULL);clk_register_clkdev(clk[ata_ahb_gate],"ata",NULL);-clk_register_clkdev(clk[rtc_ipg_gate],"rtc",NULL);+clk_register_clkdev(clk[rtc_ipg_gate],NULL,"mxc_rtc");clk_register_clkdev(clk[scc_ipg_gate],"scc",NULL);clk_register_clkdev(clk[cpu_div],"cpu",NULL);clk_register_clkdev(clk[emi_ahb_gate],"emi_ahb",NULL);
@@ -123,7 +123,7 @@ int __init mx31_clocks_init(unsigned long fref)clk_register_clkdev(clk[cspi3_gate],NULL,"imx31-cspi.2");clk_register_clkdev(clk[pwm_gate],"pwm",NULL);clk_register_clkdev(clk[wdog_gate],NULL,"imx2-wdt.0");-clk_register_clkdev(clk[rtc_gate],"rtc",NULL);+clk_register_clkdev(clk[rtc_gate],NULL,"mxc_rtc");clk_register_clkdev(clk[epit1_gate],"epit",NULL);clk_register_clkdev(clk[epit2_gate],"epit",NULL);clk_register_clkdev(clk[nfc],NULL,"mxc_nand.0");
@@ -367,14 +367,14 @@ static int __init mxc_rtc_probe(struct platform_device *pdev)pdata->ioaddr=devm_ioremap(&pdev->dev,res->start,resource_size(res));-pdata->clk=clk_get(&pdev->dev,"rtc");+pdata->clk=clk_get(&pdev->dev,NULL);if(IS_ERR(pdata->clk)){dev_err(&pdev->dev,"unable to get clock!\n");ret=PTR_ERR(pdata->clk);gotoexit_free_pdata;}-clk_enable(pdata->clk);+clk_prepare_enable(pdata->clk);rate=clk_get_rate(pdata->clk);if(rate==32768)
@@ -426,7 +426,7 @@ static int __init mxc_rtc_probe(struct platform_device *pdev)exit_clr_drvdata:platform_set_drvdata(pdev,NULL);exit_put_clk:-clk_disable(pdata->clk);+clk_disable_unprepare(pdata->clk);clk_put(pdata->clk);exit_free_pdata:
@@ -440,7 +440,7 @@ static int __exit mxc_rtc_remove(struct platform_device *pdev)rtc_device_unregister(pdata->rtc);-clk_disable(pdata->clk);+clk_disable_unprepare(pdata->clk);clk_put(pdata->clk);platform_set_drvdata(pdev,NULL);
@@ -367,14 +367,14 @@ static int __init mxc_rtc_probe(struct platform_device *pdev)pdata->ioaddr=devm_ioremap(&pdev->dev,res->start,resource_size(res));-pdata->clk=clk_get(&pdev->dev,"rtc");+pdata->clk=clk_get(&pdev->dev,NULL);
Since the rest of the driver already uses devm_, why not do it here
aswell?
Sascha
quoted hunk
if (IS_ERR(pdata->clk)) {
dev_err(&pdev->dev, "unable to get clock!\n");
ret = PTR_ERR(pdata->clk);
goto exit_free_pdata;
}
- clk_enable(pdata->clk);
+ clk_prepare_enable(pdata->clk);
rate = clk_get_rate(pdata->clk);
if (rate == 32768)
@@ -256,7 +256,7 @@ int __init mx27_clocks_init(unsigned long fref)clk_register_clkdev(clk[gpio_ipg_gate],"gpio",NULL);clk_register_clkdev(clk[brom_ahb_gate],"brom",NULL);clk_register_clkdev(clk[ata_ahb_gate],"ata",NULL);-clk_register_clkdev(clk[rtc_ipg_gate],"rtc",NULL);+clk_register_clkdev(clk[rtc_ipg_gate],NULL,"mxc_rtc");clk_register_clkdev(clk[scc_ipg_gate],"scc",NULL);clk_register_clkdev(clk[cpu_div],"cpu",NULL);clk_register_clkdev(clk[emi_ahb_gate],"emi_ahb",NULL);
@@ -123,7 +123,7 @@ int __init mx31_clocks_init(unsigned long fref)clk_register_clkdev(clk[cspi3_gate],NULL,"imx31-cspi.2");clk_register_clkdev(clk[pwm_gate],"pwm",NULL);clk_register_clkdev(clk[wdog_gate],NULL,"imx2-wdt.0");-clk_register_clkdev(clk[rtc_gate],"rtc",NULL);+clk_register_clkdev(clk[rtc_gate],NULL,"mxc_rtc");clk_register_clkdev(clk[epit1_gate],"epit",NULL);clk_register_clkdev(clk[epit2_gate],"epit",NULL);clk_register_clkdev(clk[nfc],NULL,"mxc_nand.0");
--
1.7.1
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
@@ -256,7 +256,7 @@ int __init mx27_clocks_init(unsigned long fref)clk_register_clkdev(clk[gpio_ipg_gate],"gpio",NULL);clk_register_clkdev(clk[brom_ahb_gate],"brom",NULL);clk_register_clkdev(clk[ata_ahb_gate],"ata",NULL);-clk_register_clkdev(clk[rtc_ipg_gate],"rtc",NULL);+clk_register_clkdev(clk[rtc_ipg_gate],NULL,"mxc_rtc");clk_register_clkdev(clk[scc_ipg_gate],"scc",NULL);clk_register_clkdev(clk[cpu_div],"cpu",NULL);clk_register_clkdev(clk[emi_ahb_gate],"emi_ahb",NULL);
When I look at this patch I don't know if it changes the user interface
(does it rename or move sysfs files or contents?) and I don't know
whether the patch fixes serious issues, which would indicate that a
backport into -stable is needed.
So, please read and remember these words: when fixing a bug, always
provide a complete description of that bug. Most especially, provide a
description of the end-user effects of the bug.