[PATCH] i.mx23: add dts node for mmc1/ssp1 Signed-off-by: Attila Kinali <attila@kinali.ch>

---
 arch/arm/boot/dts/imx23.dtsi |   15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/imx23.dtsi b/arch/arm/boot/dts/imx23.dtsi
index 8c5f999..df0ae8d 100644
--- a/arch/arm/boot/dts/imx23.dtsi
+++ b/arch/arm/boot/dts/imx23.dtsi

@@ -134,6 +134,21 @@
 					fsl,pinmux-ids = <0x2010 0x2060>;
 					fsl,pull-up = <0>;
 				};
+
+				mmc1_8bit_pins_a: mmc1-8bit at 0 {
+					reg = <0>;
+					fsl,pinmux-ids = <0x0002 0x0012 0x0022
+						0x0032 0x0042 0x0052 0x0062
+						0x0072 0x0142 0x0132 0x0182>;
+					fsl,drive-strength = <1>;
+					fsl,voltage = <1>;
+					fsl,pull-up = <1>;
+				};
+
+				mmc1_pins_fixup: mmc1-pins-fixup {
+					fsl,pinmux-ids = <0x0132 0x0182>;
+					fsl,pull-up = <0>;
+				};
 			};
 
 			digctl at 8001c000 {

-- 
1.7.10

Hi Attila,

On Wed, Jul 4, 2012 at 9:10 AM, Attila Kinali [off-list ref] wrote:

---
 arch/arm/boot/dts/imx23.dtsi |   15 +++++++++++++++
 1 file changed, 15 insertions(+)

Your Signed-off-by line appears in the Subject. Please fix it and resend.

Regards,

Fabio Estevam

Suggested subject prefix "ARM: dts: imx23: ..."

On Wed, Jul 04, 2012 at 02:10:33PM +0200, Attila Kinali wrote:

Please take a look at the following branch to see how these should be
formated now.

http://git.linaro.org/gitweb?p=people/shawnguo/linux-2.6.git;a=shortlog;h=refs/heads/mxs/dt-for-3.6

+					fsl,drive-strength = <1>;
+					fsl,voltage = <1>;
+					fsl,pull-up = <1>;
+				};
+
+				mmc1_pins_fixup: mmc1-pins-fixup {
+					fsl,pinmux-ids = <0x0132 0x0182>;
+					fsl,pull-up = <0>;
+				};

I do not want to have these pinctrl setup added along.  Please submit
the changes together with the <board>.dts which uses them.

Regards,
Shawn

 			};
 
 			digctl at 8001c000 {
-- 
1.7.10

On Wed, 4 Jul 2012 21:53:38 +0800
Shawn Guo [off-list ref] wrote:

Suggested subject prefix "ARM: dts: imx23: ..."

Ok

quoted

+					fsl,pinmux-ids = <0x0002 0x0012 0x0022
+						0x0032 0x0042 0x0052 0x0062
+						0x0072 0x0142 0x0132 0x0182>;

Please take a look at the following branch to see how these should be
formated now.

http://git.linaro.org/gitweb?p=people/shawnguo/linux-2.6.git;a=shortlog;h=refs/heads/mxs/dt-for-3.6

Ok

quoted

+				mmc1_pins_fixup: mmc1-pins-fixup {
+					fsl,pinmux-ids = <0x0132 0x0182>;
+					fsl,pull-up = <0>;
+				};

I do not want to have these pinctrl setup added along.  Please submit
the changes together with the <board>.dts which uses them.

I copied these from the mmc0 definition above. It could be these are
spillovers from the imx23-evk definition. Shall i move teh mmc0_pins_fixup
into the imx23-evk.dts file?

			Attila Kinali

-- 
The trouble with you, Shev, is you don't say anything until you've saved
up a whole truckload of damned heavy brick arguments and then you dump
them all out and never look at the bleeding body mangled beneath the heap
		-- Tirin, The Dispossessed, U. Le Guin

On Wed, Jul 04, 2012 at 05:09:24PM +0200, Attila Kinali wrote:

quoted

I do not want to have these pinctrl setup added along.  Please submit

Sorry. s/along/alone

quoted

the changes together with the <board>.dts which uses them.

I copied these from the mmc0 definition above. It could be these are
spillovers from the imx23-evk definition. Shall i move teh mmc0_pins_fixup
into the imx23-evk.dts file?

The changes in the patch look good.  What I meant is we need have the
user of mmc1_8bit_pins_a and mmc1_pins_fixup added together.  The
"user" means a <board>.dts which refers to these pins.

-- 
Regards,
Shawn

On Wed, 4 Jul 2012 23:26:06 +0800
Shawn Guo [off-list ref] wrote:

On Wed, Jul 04, 2012 at 05:09:24PM +0200, Attila Kinali wrote:

quoted

quoted

the changes together with the <board>.dts which uses them.

I copied these from the mmc0 definition above. It could be these are
spillovers from the imx23-evk definition. Shall i move teh mmc0_pins_fixup
into the imx23-evk.dts file?

The changes in the patch look good.  What I meant is we need have the
user of mmc1_8bit_pins_a and mmc1_pins_fixup added together.  The
"user" means a <board>.dts which refers to these pins.

Ah.. ok.. Then it will have to wait until i have the system completely
up and running. I'm still in the bring up phase and there will be
still changes in the <board>.dts (not to mention that i didn't know
about dts until yesterday and am likely to have bugs in the whole thing)

			Attila Kinali

-- 
The trouble with you, Shev, is you don't say anything until you've saved
up a whole truckload of damned heavy brick arguments and then you dump
them all out and never look at the bleeding body mangled beneath the heap
		-- Tirin, The Dispossessed, U. Le Guin