From: Fabio Estevam <redacted>
commit bc8966 (ARM: fiq: change FIQ_START to a variable) introduced the
following build error for imx_v4_v5_defconfig:
arch/arm/plat-mxc/avic.c:220:11: error: 'FIQ_START' undeclared (first use in this function)
Include the missing header file to fix it.
Signed-off-by: Fabio Estevam <redacted>
---
arch/arm/plat-mxc/avic.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Dammit. I forgot testing imx_v4_v5_defconfig again with the last FIQ
change. Thanks, Fabio.
Arnd,
I just updated the branch imx/sparse-irq with this fix applied. Can
you please pull it?
Regards,
Shawn
The following changes since commit 8842a9e2869cae14bbb8184004a42fc3070587fb:
ARM: imx: enable SPARSE_IRQ for imx platform (2012-07-01 21:59:20 +0800)
are available in the git repository at:
git://git.linaro.org/people/shawnguo/linux-2.6.git imx/sparse-irq
Fabio Estevam (1):
ARM: imx: Fix build error due to missing irqs.h include
arch/arm/plat-mxc/avic.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
On Tue, Jul 03, 2012 at 10:25:44PM -0300, Fabio Estevam wrote:
quoted hunk
From: Fabio Estevam <redacted>
commit bc8966 (ARM: fiq: change FIQ_START to a variable) introduced the
following build error for imx_v4_v5_defconfig:
arch/arm/plat-mxc/avic.c:220:11: error: 'FIQ_START' undeclared (first use in this function)
Include the missing header file to fix it.
Signed-off-by: Fabio Estevam <redacted>
---
arch/arm/plat-mxc/avic.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Dammit. I forgot testing imx_v4_v5_defconfig again with the last FIQ
change. Thanks, Fabio.
Arnd,
I just updated the branch imx/sparse-irq with this fix applied. Can
you please pull it?
In the train at the moment without internet access, so I just applied
the patch and added your S-o-b, on top of the next/irq branch.
Arnd
On Wed, Jul 04, 2012 at 10:53:02AM +0100, Russell King - ARM Linux wrote:
On Wed, Jul 04, 2012 at 11:30:22AM +0800, Shawn Guo wrote:
quoted
Dammit. I forgot testing imx_v4_v5_defconfig again with the last FIQ
change. Thanks, Fabio.
So, this begs the question - which configs have you tested this series with?
For the patch changing FIQ_START to variable, I tested the following
defconfigs.
rpc_defconfig
s3c2410_defconfig
imx_v6_v7_defconfig
As avic.c is built with imx_v6_v7_defconfig as well, I thought it's
been covered there. But it turns out that CONFIG_FIQ is not enabled
by imx_v6_v7_defconfig in any way, while it's enabled for
imx_v4_v5_defconfig because there are a couple of imx_v4_v5 audio
drivers selecting the symbol.
sound/soc/fsl/Kconfig:
config SND_SOC_IMX_PCM_FIQ
tristate
select FIQ
select SND_SOC_IMX_PCM
--
Regards,
Shawn