[PATCH 1/2] ARM: imx6q-sabrelite.dts: Add watchdog support

Subsystems: the rest

STALE5181d

5 messages, 3 authors, 2012-07-03 · open the first message on its own page

[PATCH 1/2] ARM: imx6q-sabrelite.dts: Add watchdog support

From: festevam@gmail.com (Fabio Estevam)
Date: 2012-07-02 19:50:26

From: Fabio Estevam <redacted>

Add watchdog support.

Signed-off-by: Fabio Estevam <redacted>
---
 arch/arm/boot/dts/imx6q-sabrelite.dts |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/imx6q-sabrelite.dts b/arch/arm/boot/dts/imx6q-sabrelite.dts
index e0ec929..99581a0 100644
--- a/arch/arm/boot/dts/imx6q-sabrelite.dts
+++ b/arch/arm/boot/dts/imx6q-sabrelite.dts
@@ -42,6 +42,9 @@
 				};
 			};
 
+			wdog at 020bc000 { /* WDOG1 */
+				status = "okay";
+			};
 		};
 
 		aips-bus at 02100000 { /* AIPS2 */
-- 
1.7.1

[PATCH 2/2] ARM: imx6q-sabresd.dts: Add watchdog support

From: festevam@gmail.com (Fabio Estevam)
Date: 2012-07-02 19:50:27

From: Fabio Estevam <redacted>

Add watchdog support.

Signed-off-by: Fabio Estevam <redacted>
---
 arch/arm/boot/dts/imx6q-sabresd.dts |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/imx6q-sabresd.dts b/arch/arm/boot/dts/imx6q-sabresd.dts
index 07509a1..f3002d2 100644
--- a/arch/arm/boot/dts/imx6q-sabresd.dts
+++ b/arch/arm/boot/dts/imx6q-sabresd.dts
@@ -29,6 +29,10 @@
 					status = "okay";
 				};
 			};
+
+			wdog at 020bc000 { /* WDOG1 */
+				status = "okay";
+			};
 		};
 
 		aips-bus at 02100000 { /* AIPS2 */
-- 
1.7.1

[PATCH 1/2] ARM: imx6q-sabrelite.dts: Add watchdog support

From: Shawn Guo <hidden>
Date: 2012-07-03 03:03:39

On Mon, Jul 02, 2012 at 04:50:26PM -0300, Fabio Estevam wrote:
quoted hunk
From: Fabio Estevam <redacted>

Add watchdog support.

Signed-off-by: Fabio Estevam <redacted>
---
 arch/arm/boot/dts/imx6q-sabrelite.dts |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/imx6q-sabrelite.dts b/arch/arm/boot/dts/imx6q-sabrelite.dts
index e0ec929..99581a0 100644
--- a/arch/arm/boot/dts/imx6q-sabrelite.dts
+++ b/arch/arm/boot/dts/imx6q-sabrelite.dts
@@ -42,6 +42,9 @@
 				};
 			};
 
+			wdog at 020bc000 { /* WDOG1 */
+				status = "okay";
+			};
I'm wondering if it makes more sense to have wdog, rtc, such completely
soc internal stuff always enabled in <soc>.dtsi.
 		};
 
 		aips-bus at 02100000 { /* AIPS2 */
-- 
1.7.1
-- 
Regards,
Shawn

[PATCH 1/2] ARM: imx6q-sabrelite.dts: Add watchdog support

From: s.hauer@pengutronix.de (Sascha Hauer)
Date: 2012-07-03 10:17:44

On Tue, Jul 03, 2012 at 11:03:39AM +0800, Shawn Guo wrote:
On Mon, Jul 02, 2012 at 04:50:26PM -0300, Fabio Estevam wrote:
quoted
From: Fabio Estevam <redacted>

Add watchdog support.

Signed-off-by: Fabio Estevam <redacted>
---
 arch/arm/boot/dts/imx6q-sabrelite.dts |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/imx6q-sabrelite.dts b/arch/arm/boot/dts/imx6q-sabrelite.dts
index e0ec929..99581a0 100644
--- a/arch/arm/boot/dts/imx6q-sabrelite.dts
+++ b/arch/arm/boot/dts/imx6q-sabrelite.dts
@@ -42,6 +42,9 @@
 				};
 			};
 
+			wdog at 020bc000 { /* WDOG1 */
+				status = "okay";
+			};
I'm wondering if it makes more sense to have wdog, rtc, such completely
soc internal stuff always enabled in <soc>.dtsi.
+1 for the watchdog

I'm not so sure about the rtc though, since one important component of
the RTC is not completely internal to the SoC: the battery.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[PATCH 1/2] ARM: imx6q-sabrelite.dts: Add watchdog support

From: Shawn Guo <hidden>
Date: 2012-07-03 10:39:14

On 3 July 2012 18:17, Sascha Hauer [off-list ref] wrote:
I'm not so sure about the rtc though, since one important component of
the RTC is not completely internal to the SoC: the battery.
Yes, that the case, practically.  But technically, even without
battery, RTC can also be useful for a system if only warm reset will
be performed.

Regards,
Shawn
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help