From: Lee Jones <hidden> Date: 2012-07-23 14:05:25
Hi Mark,
I was wondering if I may bother you for some help. I've been having
serious issues with testing the new mop500 sound system you have in your
ASoC for-next branch. I've fixed a few issues and will be submitting
patches shortly. The most serious issue I came across was with
recursion. Let me show you:
So here we setup the power_check function pointer with
'dapm_supply_check_power()'.
case snd_soc_dapm_regulator_supply:
case snd_soc_dapm_clock_supply:
w->power_check = dapm_supply_check_power;
break;
<snip>
}
Later we call 'dapm_widget_power_check()' which calls into the function
pointer we know to be 'dapm_supply_check_power()'.
> static int dapm_widget_power_check(struct snd_soc_dapm_widget *w)
> {
> if (w->power_checked)
> return w->new_power;
>
> if (w->force)
> w->new_power = 1;
> else
> w->new_power = w->power_check(w);
>
> w->power_checked = true;
>
> return w->new_power;
> }
The problem seems to be that 'dapm_supply_check_power()' then calls back
into 'dapm_widget_power_check()'. Then round and round we go!
/* Check to see if a power supply is needed */
static int dapm_supply_check_power(struct snd_soc_dapm_widget *w)
{
<snip>
/* Check if one of our outputs is connected */
list_for_each_entry(path, &w->sinks, list_source) {
DAPM_UPDATE_STAT(w, neighbour_checks);
if (path->weak)
continue;
if (path->connected &&
!path->connected(path->source, path->sink))
continue;
if (!path->sink)
continue;
if (dapm_widget_power_check(path->sink)) /* <-- Doh! */
return 1;
}
<snip>
}
Can you shed some light on what the correct solution might be?
Any help would be gratefully received.
Kind regards,
Lee
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
From: Mark Brown <hidden> Date: 2012-07-23 14:39:59
On Mon, Jul 23, 2012 at 03:05:19PM +0100, Lee Jones wrote:
I was wondering if I may bother you for some help. I've been having
serious issues with testing the new mop500 sound system you have in
You might want to CC some of the people who wrote that code...
The problem seems to be that 'dapm_supply_check_power()' then calls
back into 'dapm_widget_power_check()'. Then round and round we go!
Please describe what the problem you think you're seeing is, you've just
cut'n'pasted the code into your mail without describing any actual
problem in the system...
The tree walk is recursive so the fact that we call the same function
more than once isn't terribly surprising.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120723/21515a9b/attachment.sig>
From: Lee Jones <hidden> Date: 2012-07-23 14:50:09
I was wondering if I may bother you for some help. I've been having
serious issues with testing the new mop500 sound system you have in your
ASoC for-next branch. I've fixed a few issues and will be submitting
patches shortly. The most serious issue I came across was with
recursion.
It appears you can ignore this. I just tried another piece of hardware
and this problem doesn't arise, leading me to believe I have some kind
of eMMC corruption error going on with one of my boards.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
From: Lee Jones <hidden> Date: 2012-07-23 14:56:09
On 23/07/12 15:50, Lee Jones wrote:
quoted
I was wondering if I may bother you for some help. I've been having
serious issues with testing the new mop500 sound system you have in your
ASoC for-next branch. I've fixed a few issues and will be submitting
patches shortly. The most serious issue I came across was with
recursion.
It appears you can ignore this. I just tried another piece of hardware
and this problem doesn't arise, leading me to believe I have some kind
of eMMC corruption error going on with one of my boards.
FYI, just so you don't think I'm mad: http://paste.ubuntu.com/1106535/
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
From: Will Deacon <hidden> Date: 2012-07-23 18:13:10
On Mon, Jul 23, 2012 at 03:56:02PM +0100, Lee Jones wrote:
On 23/07/12 15:50, Lee Jones wrote:
quoted
quoted
I was wondering if I may bother you for some help. I've been having
serious issues with testing the new mop500 sound system you have in your
ASoC for-next branch. I've fixed a few issues and will be submitting
patches shortly. The most serious issue I came across was with
recursion.
It appears you can ignore this. I just tried another piece of hardware
and this problem doesn't arise, leading me to believe I have some kind
of eMMC corruption error going on with one of my boards.
I still maintain that you're getting memory corruption as a result of your
linear mapping getting screwed up:
Truncating RAM at 18000000-3fffffff to -2c3fffff (vmalloc region overlap).
looks wrong to me. Your command line also has some non-standard mem= options
that I don't understand:
vmalloc=300M mem=128M at 0 mali.mali_mem=64M at 128M hwmem=168M at 192M mem=22M at 360M mem_issw=1M at 383M mem=640M at 384M
I'd guess you need highmem to map that lot, but you don't appear to have that
enabled and you end up with a rather strange amount of reported memory to go
with your lowmem mapping:
Memory: 474156k/474156k available, 11220k reserved, 0K highmem
Virtual kernel memory layout:
vector : 0xffff0000 - 0xffff1000 ( 4 kB)
fixmap : 0xfff00000 - 0xfffe0000 ( 896 kB)
vmalloc : 0xec800000 - 0xff000000 ( 296 MB)
lowmem : 0xc0000000 - 0xec400000 ( 708 MB)
Now, I don't know a thing about Snowball, so maybe this is all normal for
that board but if you're seeing memory corruption I'd get to the bottom of
this before trying to debug instances of it cropping up in random driver
code :)
Will
From: Lee Jones <hidden> Date: 2012-07-24 07:26:42
On 23/07/12 19:12, Will Deacon wrote:
On Mon, Jul 23, 2012 at 03:56:02PM +0100, Lee Jones wrote:
quoted
On 23/07/12 15:50, Lee Jones wrote:
quoted
quoted
I was wondering if I may bother you for some help. I've been having
serious issues with testing the new mop500 sound system you have in your
ASoC for-next branch. I've fixed a few issues and will be submitting
patches shortly. The most serious issue I came across was with
recursion.
It appears you can ignore this. I just tried another piece of hardware
and this problem doesn't arise, leading me to believe I have some kind
of eMMC corruption error going on with one of my boards.
I still maintain that you're getting memory corruption as a result of your
linear mapping getting screwed up:
Truncating RAM at 18000000-3fffffff to -2c3fffff (vmalloc region overlap).
looks wrong to me. Your command line also has some non-standard mem= options
that I don't understand:
Yes, I am inclined to agree with you. I just thought it was
uncharacteristic of a memory corruption error, as can reliably reproduce
the bootlog above. What's even more strange is that the issue only
arises on one of my two _identical_ development boards.
vmalloc=300M mem=128M at 0 mali.mali_mem=64M at 128M hwmem=168M at 192M mem=22M at 360M mem_issw=1M at 383M mem=640M at 384M
I'd guess you need highmem to map that lot, but you don't appear to have that
enabled and you end up with a rather strange amount of reported memory to go
with your lowmem mapping:
Memory: 474156k/474156k available, 11220k reserved, 0K highmem
Virtual kernel memory layout:
vector : 0xffff0000 - 0xffff1000 ( 4 kB)
fixmap : 0xfff00000 - 0xfffe0000 ( 896 kB)
vmalloc : 0xec800000 - 0xff000000 ( 296 MB)
lowmem : 0xc0000000 - 0xec400000 ( 708 MB)
Enabling HIGHMEM is actually on my TODO list. We have it enabled in our
release kernel, it's just on in Mainline yet. I'll bring it forward and
make it the next think I do.
Now, I don't know a thing about Snowball, so maybe this is all normal for
that board but if you're seeing memory corruption I'd get to the bottom of
this before trying to debug instances of it cropping up in random driver
code :)
I don't have any allocated time to debug issues which only arise on
Snowball. I'm just waiting on another piece of hardware, then I can
start testing on the u9540. This issue will be the first thing I test for.
Thanks for your time chaps.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
From: Mark Brown <hidden> Date: 2012-07-24 22:46:53
On Tue, Jul 24, 2012 at 08:26:36AM +0100, Lee Jones wrote:
Yes, I am inclined to agree with you. I just thought it was
uncharacteristic of a memory corruption error, as can reliably reproduce
the bootlog above. What's even more strange is that the issue only
arises on one of my two _identical_ development boards.
It's not that unusual depending on where the cause is - for example,
copying an initialised struct to the wrong place, and things like the
DAPM graph which are big and pointer driven are often affected.