[PATCH] mfd: da9052: fix of_match_node() arguments
Subsystems:
dialog semiconductor drivers, multifunction devices (mfd), the rest
STALE5234d
3 messages,
3 authors,
2012-05-09 · open the first message on its own page
The driver calls of_match_node() with the arguments swapped.
Signed-off-by: Olof Johansson <redacted>
---
drivers/mfd/da9052-i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/da9052-i2c.c b/drivers/mfd/da9052-i2c.c
index d8abdb3..8410065 100644
--- a/drivers/mfd/da9052-i2c.c
+++ b/drivers/mfd/da9052-i2c.c
@@ -104,7 +104,7 @@ static int __devinit da9052_i2c_probe(struct i2c_client *client,
struct device_node *np = client->dev.of_node;
const struct of_device_id *deviceid;
- deviceid = of_match_node(np, dialog_dt_ids);
+ deviceid = of_match_node(dialog_dt_ids, np);
id = (const struct i2c_device_id *)deviceid->data;
}
#endif
--
1.7.9.5
(2012?05?06? 07:02), Olof Johansson wrote:
quoted hunk
The driver calls of_match_node() with the arguments swapped.
Signed-off-by: Olof Johansson <redacted>
---
drivers/mfd/da9052-i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/da9052-i2c.c b/drivers/mfd/da9052-i2c.c
index d8abdb3..8410065 100644
--- a/drivers/mfd/da9052-i2c.c
+++ b/drivers/mfd/da9052-i2c.c
@@ -104,7 +104,7 @@ static int __devinit da9052_i2c_probe(struct i2c_client *client,
struct device_node *np = client->dev.of_node;
const struct of_device_id *deviceid;
- deviceid = of_match_node(np, dialog_dt_ids);
+ deviceid = of_match_node(dialog_dt_ids, np);
id = (const struct i2c_device_id *)deviceid->data;
}
#endif
Tested-by: Ying-Chun Liu <redacted>
Sorry. I don't know how my code works and tested previously.
But your patch is definited correct.
Hi Olof,
On Sat, May 05, 2012 at 04:02:48PM -0700, Olof Johansson wrote:
The driver calls of_match_node() with the arguments swapped.
Thanks, patch applied to my for-next branch.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/