[PATCH] ARM: include linux/bug.h in insn.c

Subsystems: arm port, the rest

STALE5245d

4 messages, 4 authors, 2012-03-31 · open the first message on its own page

[PATCH] ARM: include linux/bug.h in insn.c

From: Joachim Eastwood <hidden>
Date: 2012-03-30 21:13:22

After commit d82227cf8 building the kernel fails with:
  arch/arm/kernel/insn.c: In function '__arm_gen_branch_thumb2':
  arch/arm/kernel/insn.c:13: error: implicit declaration of function 'WARN_ON_ONCE'
  make[1]: *** [arch/arm/kernel/insn.o] Error 1
  make: *** [arch/arm/kernel] Error 2

insn.c uses WARN_ON_ONCE so lets include bug.h.

Signed-off-by: Joachim Eastwood <redacted>
---
 arch/arm/kernel/insn.c |    1 +
 1 file changed, 1 insertion(+)
diff --git a/arch/arm/kernel/insn.c b/arch/arm/kernel/insn.c
index ab312e5..080fc70 100644
--- a/arch/arm/kernel/insn.c
+++ b/arch/arm/kernel/insn.c
@@ -1,4 +1,5 @@
 #include <linux/kernel.h>
+#include <linux/bug.h>
 #include <asm/opcodes.h>
 
 static unsigned long
-- 
1.7.9.2

[PATCH] ARM: include linux/bug.h in insn.c

From: Paul Gortmaker <hidden>
Date: 2012-03-30 22:06:07

On Fri, Mar 30, 2012 at 5:13 PM, Joachim Eastwood [off-list ref] wrote:
After commit d82227cf8 building the kernel fails with:
Please also list the shortlog when giving a commit ID, i.e.

   "ARM: 7331/1: extract out insn generation code from ftrace"

Thanks,
Paul.
quoted hunk
?arch/arm/kernel/insn.c: In function '__arm_gen_branch_thumb2':
?arch/arm/kernel/insn.c:13: error: implicit declaration of function 'WARN_ON_ONCE'
?make[1]: *** [arch/arm/kernel/insn.o] Error 1
?make: *** [arch/arm/kernel] Error 2

insn.c uses WARN_ON_ONCE so lets include bug.h.

Signed-off-by: Joachim Eastwood <redacted>
---
?arch/arm/kernel/insn.c | ? ?1 +
?1 file changed, 1 insertion(+)
diff --git a/arch/arm/kernel/insn.c b/arch/arm/kernel/insn.c
index ab312e5..080fc70 100644
--- a/arch/arm/kernel/insn.c
+++ b/arch/arm/kernel/insn.c
@@ -1,4 +1,5 @@
?#include <linux/kernel.h>
+#include <linux/bug.h>
?#include <asm/opcodes.h>

?static unsigned long
--
1.7.9.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH] ARM: include linux/bug.h in insn.c

From: Russell King - ARM Linux <hidden>
Date: 2012-03-31 08:16:59

On Fri, Mar 30, 2012 at 11:13:22PM +0200, Joachim Eastwood wrote:
After commit d82227cf8 building the kernel fails with:
  arch/arm/kernel/insn.c: In function '__arm_gen_branch_thumb2':
  arch/arm/kernel/insn.c:13: error: implicit declaration of function 'WARN_ON_ONCE'
  make[1]: *** [arch/arm/kernel/insn.o] Error 1
  make: *** [arch/arm/kernel] Error 2

insn.c uses WARN_ON_ONCE so lets include bug.h.
I already have this in my tree.

[PATCH] ARM: include linux/bug.h in insn.c

From: Sergei Shtylyov <hidden>
Date: 2012-03-31 21:21:59

Hello.

On 31-03-2012 1:13, Joachim Eastwood wrote:
After commit d82227cf8 building the kernel fails with:
    Please also specify that commit summary in parens.
   arch/arm/kernel/insn.c: In function '__arm_gen_branch_thumb2':
   arch/arm/kernel/insn.c:13: error: implicit declaration of function 'WARN_ON_ONCE'
   make[1]: *** [arch/arm/kernel/insn.o] Error 1
   make: *** [arch/arm/kernel] Error 2
insn.c uses WARN_ON_ONCE so lets include bug.h.
    Let's.
Signed-off-by: Joachim Eastwood<redacted>
WBR, Sergei
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help