[PATCH] ARM: OMAP2+: Fix omap2+ build error.

Subsystems: arm port, the rest

STALE5242d REVIEWED: 1 (0M)

1 review trailer.

2 messages, 2 authors, 2012-03-30 · open the first message on its own page

[PATCH] ARM: OMAP2+: Fix omap2+ build error.

From: R Sricharan <hidden>
Date: 2012-03-30 08:35:16

With CONFIG_OMAP4_ERRATA_I688 enabled, omap2+ build
was broken as below.

	arch/arm/kernel/io.c: In function '_memcpy_toio':
	arch/arm/kernel/io.c:29: error: implicit declaration of function 'outer_sync'
	make[1]: *** [arch/arm/kernel/io.o] Error 1

Fixing this here.

Signed-off-by: R Sricharan <redacted>
Acked-by: Santosh Shilimkar <redacted>
---
 arch/arm/include/asm/barrier.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/include/asm/barrier.h b/arch/arm/include/asm/barrier.h
index 44f4a09..0511238 100644
--- a/arch/arm/include/asm/barrier.h
+++ b/arch/arm/include/asm/barrier.h
@@ -2,6 +2,7 @@
 #define __ASM_BARRIER_H
 
 #ifndef __ASSEMBLY__
+#include <asm/outercache.h>
 
 #define nop() __asm__ __volatile__("mov\tr0,r0\t@ nop\n\t");
 
@@ -39,7 +40,6 @@
 #ifdef CONFIG_ARCH_HAS_BARRIERS
 #include <mach/barriers.h>
 #elif defined(CONFIG_ARM_DMA_MEM_BUFFERABLE) || defined(CONFIG_SMP)
-#include <asm/outercache.h>
 #define mb()		do { dsb(); outer_sync(); } while (0)
 #define rmb()		dsb()
 #define wmb()		mb()
-- 
1.7.1

[PATCH] ARM: OMAP2+: Fix omap2+ build error.

From: Shilimkar, Santosh <hidden>
Date: 2012-03-30 08:49:33

On Fri, Mar 30, 2012 at 2:05 PM, R Sricharan [off-list ref] wrote:
With CONFIG_OMAP4_ERRATA_I688 enabled, omap2+ build
was broken as below.

? ? ? ?arch/arm/kernel/io.c: In function '_memcpy_toio':
? ? ? ?arch/arm/kernel/io.c:29: error: implicit declaration of function 'outer_sync'
? ? ? ?make[1]: *** [arch/arm/kernel/io.o] Error 1

Fixing this here.

Signed-off-by: R Sricharan <redacted>
Acked-by: Santosh Shilimkar <redacted>
---
?arch/arm/include/asm/barrier.h | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)
Can you please add information about the commit
after this was broken.

Regards
santosh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help