[PATCH 0/2] ARM: OMAP2+: PM: code consolidation for 3.4

Paul Walmsley [off-list ref] writes:

Hi

This series consolidates some duplicated PM code across OMAP2, 3, and 4.
This saves both binary kernel image size, and lines of source.  These
functions are just the low-hanging fruit; it looks to me like there's even
more consolidation that could be done.

Suspend + UART wakeup was tested on OMAP44xx BeagleBoard.  

I assume you meant Panda board?

On the OMAP35xx Beagleboard here, v3.3-rc2 doesn't seem to wake up
from suspend correctly with or without these patches, so I've only
boot-tested them on that platform.

I also tested idle & suspend + UART wakeup on 3430/n900, 3530/Overo.

Will add these to my cleanup queue for v3.4[1] after adding a Tested-by
from Santosh.

Kevin

[1]
git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git for_3.4/cleanup/pm

On Thu, 2 Feb 2012, Kevin Hilman wrote:

Paul Walmsley [off-list ref] writes:

quoted

Suspend + UART wakeup was tested on OMAP44xx BeagleBoard.  

I assume you meant Panda board?

Yep

quoted

On the OMAP35xx Beagleboard here, v3.3-rc2 doesn't seem to wake up
from suspend correctly with or without these patches, so I've only
boot-tested them on that platform.

I also tested idle & suspend + UART wakeup on 3430/n900, 3530/Overo.

Will add these to my cleanup queue for v3.4[1] after adding a Tested-by
from Santosh.

Great.  Do you know what the deal is with suspend on 34xx?  I enabled 
ttyO2 wakeup and entered suspend, but serial traffic doesn't bring it out?


- Paul

On Thu, 2 Feb 2012, Paul Walmsley wrote:

Great.  Do you know what the deal is with suspend on 34xx?  I enabled 
ttyO2 wakeup and entered suspend, but serial traffic doesn't bring it out?

Just a quick followup; Kevin tracked this down.  v3.3-rc needs the MTD 
suspend patch that Artem posted recently to suspend correctly on OMAP35xx 
BeagleBoard with omap2plus_defconfig.  Thanks Kevin.


- Paul

Hi,

On Thu, Feb 2, 2012 at 10:29 PM, Paul Walmsley [off-list ref] wrote:

On Thu, 2 Feb 2012, Paul Walmsley wrote:

quoted

Great. ?Do you know what the deal is with suspend on 34xx? ?I enabled
ttyO2 wakeup and entered suspend, but serial traffic doesn't bring it out?

Just a quick followup; Kevin tracked this down. ?v3.3-rc needs the MTD
suspend patch that Artem posted recently to suspend correctly on OMAP35xx
BeagleBoard with omap2plus_defconfig. ?Thanks Kevin.

I can't get ttyO2 wakeup to work on my Blaze with 3.3-rc5.  It works
fine with 3.2.  I've been trying to bisect and everything, but it's
difficult.  To start with, during my bisect, many patches seem to be
in a state where the compilation fails (one example is
'OMAP44XX_IRQ_PRCM' undeclared).

Anyway, what I found out is that after fcf6efa3 (ARM: OMAP4: PM: Add
WakeupGen module as OMAP gic_arch_extn) wakeup from the console
doesn't work anymore for me.  Then I tried to comment out the
omap_wakeupgen_init() call in  gic_init_irq() and that seems to
work... for a while.  At least until ff819da4 (ARM: OMAP3: CPUidle:
Make use of CPU PM notifiers) commenting out that line seems to work.
But it doesn't work if I comment out the line with v3.3-rc5.

And that's when I reckoned I've been using too much time trying to
figure this one out. :)

Does anyone know how to solve this?

-- 
Cheers,
Luca.

Hi Luciano,

On Thu, 8 Mar 2012, Coelho, Luciano wrote:

I can't get ttyO2 wakeup to work on my Blaze with 3.3-rc5.  It works
fine with 3.2.  I've been trying to bisect and everything, but it's
difficult.  To start with, during my bisect, many patches seem to be
in a state where the compilation fails (one example is
'OMAP44XX_IRQ_PRCM' undeclared).

Anyway, what I found out is that after fcf6efa3 (ARM: OMAP4: PM: Add
WakeupGen module as OMAP gic_arch_extn) wakeup from the console
doesn't work anymore for me.  Then I tried to comment out the
omap_wakeupgen_init() call in  gic_init_irq() and that seems to
work... for a while.  At least until ff819da4 (ARM: OMAP3: CPUidle:
Make use of CPU PM notifiers) commenting out that line seems to work.
But it doesn't work if I comment out the line with v3.3-rc5.

Maybe try this patch:

http://www.spinics.net/lists/linux-omap/msg65786.html

If that doesn't work, could you try to reproduce with omap2plus_defconfig 
and a boring kernel command line?


- Paul