[PATCH v3] ARM: davinci: map default_queue to edma channels
From: Heiko Schocher <hidden>
Date: 2012-01-19 07:05:21
Default queue is expected to be a low-priority queue.
This way, long transfers on the default queue started
by the codec engine will not cause audio defects.
Signed-off-by: Heiko Schocher <redacted>
Signed-off-by: juha.kuikka at gmail.com
Reported-by: juha.kuikka at gmail.com
Acked-by: Rajashekhara, Sudhakar <redacted>
Cc: linux-mmc at vger.kernel.org
Cc: davinci-linux-open-source at linux.davincidsp.com
Cc: linux-arm-kernel at lists.infradead.org
Cc: Rajashekhara, Sudhakar <redacted>
Cc: Ido Yariv <redacted>
Cc: Sekhar Nori <redacted>
Cc: Wolfgang Denk <redacted>
Cc: Sergei Shtylyov <redacted>
---
- changes for v2:
- add comment from Sergei Shtylyov
add in commit message the commit's summary in parens.
- add comment from Ido Yariv:
changed comment and commit message
- added Acked-by from Rajashekhara, Sudhakar
- changes for v3:
- add comments from Sekhar Nori [off-list ref]:
- add linux-arm-kernel at lists.infradead.org to Cc
- simplify and move comment to
arch/arm/mach-davinci/include/mach/edma.h
- rework commit message
- as the subject changed v2 can be found for example here:
http://linux.davincidsp.com/pipermail/davinci-linux-open-source/2011-December/023606.html
- checkpatch shows:
total: 0 errors, 0 warnings, 24 lines checked
temp/0001-ARM-davinci-map-default_queue-to-edma-channels.patch has no obvious style problems and is ready for submission.
arch/arm/mach-davinci/dma.c | 6 +-----
arch/arm/mach-davinci/include/mach/edma.h | 5 +++++
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/arch/arm/mach-davinci/dma.c b/arch/arm/mach-davinci/dma.c
index da90103..fd33919 100644
--- a/arch/arm/mach-davinci/dma.c
+++ b/arch/arm/mach-davinci/dma.c@@ -1508,12 +1508,8 @@ static int __init edma_probe(struct platform_device *pdev) goto fail; } - /* Everything lives on transfer controller 1 until otherwise - * specified. This way, long transfers on the low priority queue - * started by the codec engine will not cause audio defects. - */ for (i = 0; i < edma_cc[j]->num_channels; i++) - map_dmach_queue(j, i, EVENTQ_1); + map_dmach_queue(j, i, info[j]->default_queue); queue_tc_mapping = info[j]->queue_tc_mapping; queue_priority_mapping = info[j]->queue_priority_mapping;
diff --git a/arch/arm/mach-davinci/include/mach/edma.h b/arch/arm/mach-davinci/include/mach/edma.h
index 20c77f2..7e84c90 100644
--- a/arch/arm/mach-davinci/include/mach/edma.h
+++ b/arch/arm/mach-davinci/include/mach/edma.h@@ -250,6 +250,11 @@ struct edma_soc_info { unsigned n_slot; unsigned n_tc; unsigned n_cc; + /* + * Default queue is expected to be a low-priority queue. + * This way, long transfers on the default queue started + * by the codec engine will not cause audio defects. + */ enum dma_event_q default_queue; /* Resource reservation for other cores */
--
1.7.7.5