This patch fixes following building error:
--
arch/arm/mach-footbridge/dc21285.c: In function 'dc21285_preinit':
arch/arm/mach-footbridge/dc21285.c:299:2: error: 'vga_base' undeclared (first use in this function)
arch/arm/mach-footbridge/dc21285.c:299:2: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [arch/arm/mach-footbridge/dc21285.o] Error 1
--
Signed-off-by: Bryan Wu <redacted>
---
arch/arm/mach-footbridge/dc21285.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Russell,
Also this one. any comment?
Thanks,
-Bryan
On Wed, Aug 17, 2011 at 6:00 PM, Bryan Wu [off-list ref] wrote:
quoted hunk
This patch fixes following building error:
--
arch/arm/mach-footbridge/dc21285.c: In function 'dc21285_preinit':
arch/arm/mach-footbridge/dc21285.c:299:2: error: 'vga_base' undeclared (first use in this function)
arch/arm/mach-footbridge/dc21285.c:299:2: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [arch/arm/mach-footbridge/dc21285.o] Error 1
--
Signed-off-by: Bryan Wu <redacted>
---
?arch/arm/mach-footbridge/dc21285.c | ? ?1 +
?1 files changed, 1 insertions(+), 0 deletions(-)
From: Russell King - ARM Linux <hidden> Date: 2011-08-21 08:41:04
On Fri, Aug 19, 2011 at 12:37:09PM +0800, Bryan Wu wrote:
Russell,
Also this one. any comment?
Other than frustration that Rob Herring isn't responding to his breakage
(which is making me want to ignore further patches from Rob - clearly
doesn't care about the effect of his c9d95fb "ARM: convert PCI defines
to variables" patch...)
It looks obviously correct.
On Sun, Aug 21, 2011 at 4:41 PM, Russell King - ARM Linux
[off-list ref] wrote:
On Fri, Aug 19, 2011 at 12:37:09PM +0800, Bryan Wu wrote:
quoted
Russell,
Also this one. any comment?
Other than frustration that Rob Herring isn't responding to his breakage
(which is making me want to ignore further patches from Rob - clearly
doesn't care about the effect of his c9d95fb "ARM: convert PCI defines
to variables" patch...)
I forgot to add Rob in this email loop. Added now.
It looks obviously correct.
Thanks,
--
Bryan Wu [off-list ref]
Kernel Developer ? ?+86.138-1617-6545 Mobile
Ubuntu Kernel Team
Canonical Ltd. ? ? ?www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com
From: Rob Herring <hidden> Date: 2011-08-21 18:35:35
On 08/21/2011 10:36 AM, Bryan Wu wrote:
On Sun, Aug 21, 2011 at 4:41 PM, Russell King - ARM Linux
[off-list ref] wrote:
quoted
On Fri, Aug 19, 2011 at 12:37:09PM +0800, Bryan Wu wrote:
quoted
Russell,
Also this one. any comment?
Other than frustration that Rob Herring isn't responding to his breakage
(which is making me want to ignore further patches from Rob - clearly
doesn't care about the effect of his c9d95fb "ARM: convert PCI defines
to variables" patch...)
Sorry, I've been away on vacation Wed-Sat.
I forgot to add Rob in this email loop. Added now.
Thanks for copying me directly.
quoted
It looks obviously correct.
I went back to check for other instances and found orion5x is also
broken missing this include. It is also broken by another commit which
I'll fix. Patches coming soon.
Rob