[PATCH] ARM: omap4: rename gpmc clock to gpmc_ick

STALE5510d

2 messages, 2 authors, 2011-07-05 · open the first message on its own page

[PATCH] ARM: omap4: rename gpmc clock to gpmc_ick

From: Kevin Hilman <hidden>
Date: 2011-07-05 18:35:00

Santosh Shilimkar [off-list ref] writes:
+ Benoit

On 7/5/2011 5:19 AM, Jan Weitzel wrote:
quoted
The gpmc clock on omap44xx is called gpmc_ick not gpmc_ck in
clock44xx_data.c

Signed-off-by: Jan Weitzel<redacted>
This happened after renaming the clock-nodes some time back.
Looks good to me as a fix though in long run GPMC should be
moved to hwmod to avoid such naming issues
In fact, Benoit has already done it[1] as part of his last series:
[PATCH v2 0/4] OMAP4: Add modulemode support to hwmod framework (part 2)

Kevin

[1] http://marc.info/?l=linux-omap&m=130955728217211&w=2

[PATCH] ARM: omap4: rename gpmc clock to gpmc_ick

From: Santosh Shilimkar <hidden>
Date: 2011-07-05 18:42:15

On 7/5/2011 11:35 AM, Kevin Hilman wrote:
Santosh Shilimkar[off-list ref]  writes:
quoted
+ Benoit

On 7/5/2011 5:19 AM, Jan Weitzel wrote:
quoted
The gpmc clock on omap44xx is called gpmc_ick not gpmc_ck in
clock44xx_data.c

Signed-off-by: Jan Weitzel<redacted>
This happened after renaming the clock-nodes some time back.
Looks good to me as a fix though in long run GPMC should be
moved to hwmod to avoid such naming issues
In fact, Benoit has already done it[1] as part of his last series:
[PATCH v2 0/4] OMAP4: Add modulemode support to hwmod framework (part 2)
Ohh yes. I remember now about the discussion with him on the GPMC patch
which he did as a followup patch to mine similar clock framework
patch [1]

Thanks for the link.

Regards
Santosh
[1] https://patchwork.kernel.org/patch/937422/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help