DORMANTno replies

[PATCH] arm: kernel: module: Remove the r_offset check which is always false

From: Maxin John <hidden>
Date: 2011-05-06 16:52:01
Also in: lkml
Subsystem: arm port, the rest · Maintainers: Russell King, Linus Torvalds

Checking the unsigned 'r_offset' for less than zero will always be false.

Signed-off-by: Maxin B. John <redacted>
---
diff --git a/arch/arm/kernel/module.c b/arch/arm/kernel/module.c
index fee7c36..fc74bd3 100644
--- a/arch/arm/kernel/module.c
+++ b/arch/arm/kernel/module.c
@@ -92,7 +92,7 @@ apply_relocate(Elf32_Shdr *sechdrs, const char
*strtab, unsigned int symindex,
                sym = ((Elf32_Sym *)symsec->sh_addr) + offset;
                symname = strtab + sym->st_name;

-               if (rel->r_offset < 0 || rel->r_offset >
dstsec->sh_size - sizeof(u32)) {
+               if (rel->r_offset > dstsec->sh_size - sizeof(u32)) {
                        pr_err("%s: section %u reloc %u sym '%s': out
of bounds relocation, offset %d size %u\n",
                               module->name, relindex, i, symname,
                               rel->r_offset, dstsec->sh_size);
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help