From: Stephen Boyd <hidden> Date: 2011-03-21 23:51:17
Commit d232b12 (asm-generic headers: add sizes.h, 2011-01-15)
introduced a generic sizes.h. Use that instead of the ARM specific
version.
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Stephen Boyd <redacted>
---
arch/arm/include/asm/sizes.h | 60 +-----------------------------------------
1 files changed, 1 insertions(+), 59 deletions(-)
Commit d232b12 (asm-generic headers: add sizes.h, 2011-01-15)
introduced a generic sizes.h. Use that instead of the ARM specific
version.
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Stephen Boyd <redacted>
From: Russell King - ARM Linux <hidden> Date: 2011-03-22 09:21:28
On Tue, Mar 22, 2011 at 09:34:50AM +0100, Arnd Bergmann wrote:
On Tuesday 22 March 2011, Stephen Boyd wrote:
quoted
Commit d232b12 (asm-generic headers: add sizes.h, 2011-01-15)
introduced a generic sizes.h. Use that instead of the ARM specific
version.
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Stephen Boyd <redacted>
Acked-by: Arnd Bergmann <arnd@arndb.de
I assume the generic version was derived from the ARM version. Is there
a reason why ARM Ltd's copyright was seemingly dropped?
On Tuesday 22 March 2011, Russell King - ARM Linux wrote:
On Tue, Mar 22, 2011 at 09:34:50AM +0100, Arnd Bergmann wrote:
quoted
On Tuesday 22 March 2011, Stephen Boyd wrote:
quoted
Commit d232b12 (asm-generic headers: add sizes.h, 2011-01-15)
introduced a generic sizes.h. Use that instead of the ARM specific
version.
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Stephen Boyd <redacted>
Acked-by: Arnd Bergmann <arnd@arndb.de
I assume the generic version was derived from the ARM version. Is there
a reason why ARM Ltd's copyright was seemingly dropped?
I'll let Guan Xuetao answer that, he introduced the file along with the
unicore32 architecture.
I doubt that the contents of this file are copyrightable, but of course
that is normally no reason to remove the notice.
Arnd
Firstly, the sizes.h is do derived from arm version.
And I just complete the SZ_* definitions for 32-bit architecture,
and remove SZ_48M for not being power-of-2 size.
I am sorry for removing copyright information when cleaning-up the code.
However, the content of this file is so common sense for handy sizes.
So, I believe that GPLv2 license is enough.
Regards.
Guan Xuetao
-----Original Message-----
From: Arnd Bergmann [mailto:arnd at arndb.de]
Sent: Tuesday, March 22, 2011 6:10 PM
To: linux-arm-kernel at lists.infradead.org; Guan Xuetao
Cc: Russell King - ARM Linux; Stephen Boyd; linux-kernel at vger.kernel.org
Subject: Re: [PATCH] ARM: Use asm-generic/sizes.h
On Tuesday 22 March 2011, Russell King - ARM Linux wrote:
quoted
On Tue, Mar 22, 2011 at 09:34:50AM +0100, Arnd Bergmann wrote:
quoted
On Tuesday 22 March 2011, Stephen Boyd wrote:
quoted
Commit d232b12 (asm-generic headers: add sizes.h, 2011-01-15)
introduced a generic sizes.h. Use that instead of the ARM specific
version.
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Stephen Boyd <redacted>
Acked-by: Arnd Bergmann <arnd@arndb.de
I assume the generic version was derived from the ARM version. Is there
a reason why ARM Ltd's copyright was seemingly dropped?
I'll let Guan Xuetao answer that, he introduced the file along with the
unicore32 architecture.
I doubt that the contents of this file are copyrightable, but of course
that is normally no reason to remove the notice.
Arnd
-----Original Message-----
From: Stephen Boyd [mailto:sboyd at codeaurora.org]
Sent: Wednesday, March 23, 2011 2:40 AM
To: Guan Xuetao
Cc: 'Arnd Bergmann'; linux-arm-kernel at lists.infradead.org; 'Russell King - ARM Linux'; linux-kernel at vger.kernel.org
Subject: Re: [PATCH] ARM: Use asm-generic/sizes.h
On 03/22/2011 06:43 AM, Guan Xuetao wrote:
quoted
And I just complete the SZ_* definitions for 32-bit architecture,
and remove SZ_48M for not being power-of-2 size.
Ah, I didn't notice this part. SZ_48M is actually used by ARM code so
that would need to be added to the generic header should we go with this
patch.
IMO, the content of asm-generic/sizes.h should only include power-of-2 sizes definitions.
And SZ_48M could be replaced by (SZ_32M | SZ_16M) or (SZ_32M + SZ_16M), or added to arch-specific headers.
Guan Xuetao
From: Stephen Boyd <hidden> Date: 2011-03-23 03:16:46
On 03/22/2011 06:29 PM, Guan Xuetao wrote:
quoted
-----Original Message-----
From: Stephen Boyd [mailto:sboyd at codeaurora.org]
Sent: Wednesday, March 23, 2011 2:40 AM
To: Guan Xuetao
Cc: 'Arnd Bergmann'; linux-arm-kernel at lists.infradead.org; 'Russell King - ARM Linux'; linux-kernel at vger.kernel.org
Subject: Re: [PATCH] ARM: Use asm-generic/sizes.h
Ah, I didn't notice this part. SZ_48M is actually used by ARM code so
that would need to be added to the generic header should we go with this
patch.
IMO, the content of asm-generic/sizes.h should only include power-of-2 sizes definitions.
And SZ_48M could be replaced by (SZ_32M | SZ_16M) or (SZ_32M + SZ_16M), or added to arch-specific headers.
I'm hoping that kbuild gets asm-generic support sometime soon so files
with only a "#include <asm-generic/*>" are generated instead of living
in the tree. In that case I'd rather have the non power of 2 constants
added to the generic sizes.h and be done with it. There isn't any strong
technical reason to deny power of 2 constants from the generic header,
right?
Note: SH could also move to this if SZ_26M is put in the generic header.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
From: Paul Mundt <hidden> Date: 2011-03-23 04:07:30
On Tue, Mar 22, 2011 at 08:16:38PM -0700, Stephen Boyd wrote:
On 03/22/2011 06:29 PM, Guan Xuetao wrote:
quoted
IMO, the content of asm-generic/sizes.h should only include
power-of-2 sizes definitions. And SZ_48M could be replaced by
(SZ_32M | SZ_16M) or (SZ_32M + SZ_16M), or added to arch-specific
headers.
I'm hoping that kbuild gets asm-generic support sometime soon so files
with only a "#include <asm-generic/*>" are generated instead of living
in the tree. In that case I'd rather have the non power of 2 constants
added to the generic sizes.h and be done with it. There isn't any strong
technical reason to deny power of 2 constants from the generic header,
right?
Note: SH could also move to this if SZ_26M is put in the generic header.
I since dropped it and just open-coded it in the one place it was being
used. If it had been used in more places I would have stubbed it in the
asm/ version after the asm-generic include.
I'd say the simplest is to stay with powers of 2 unless you have a size
that is used in more than one place. If ARM uses SZ_48M commonly then
there's certainly a good case for adding it generically.
-----Original Message-----
From: Stephen Boyd [mailto:sboyd at codeaurora.org]
Sent: Wednesday, March 23, 2011 11:17 AM
To: Guan Xuetao
Cc: 'Russell King - ARM Linux'; linux-arm-kernel at lists.infradead.org; 'Arnd Bergmann'; linux-kernel at vger.kernel.org
Subject: Re: [PATCH] ARM: Use asm-generic/sizes.h
On 03/22/2011 06:29 PM, Guan Xuetao wrote:
quoted
quoted
-----Original Message-----
From: Stephen Boyd [mailto:sboyd at codeaurora.org]
Sent: Wednesday, March 23, 2011 2:40 AM
To: Guan Xuetao
Cc: 'Arnd Bergmann'; linux-arm-kernel at lists.infradead.org; 'Russell King - ARM Linux'; linux-kernel at vger.kernel.org
Subject: Re: [PATCH] ARM: Use asm-generic/sizes.h
Ah, I didn't notice this part. SZ_48M is actually used by ARM code so
that would need to be added to the generic header should we go with this
patch.
IMO, the content of asm-generic/sizes.h should only include power-of-2 sizes definitions.
And SZ_48M could be replaced by (SZ_32M | SZ_16M) or (SZ_32M + SZ_16M), or added to arch-specific headers.
I'm hoping that kbuild gets asm-generic support sometime soon so files
with only a "#include <asm-generic/*>" are generated instead of living
in the tree. In that case I'd rather have the non power of 2 constants
added to the generic sizes.h and be done with it. There isn't any strong
technical reason to deny power of 2 constants from the generic header,
right?
No.
I just think that power-of-2 sizes are more generic, not compulsively of course.
Sam Ravnborg had introduced a patch set to provide generic support for
architectures that using one-line asm-generic headers.
CC: Sam Ravnborg <redacted>
Note: SH could also move to this if SZ_26M is put in the generic header.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
From: Sam Ravnborg <hidden> Date: 2011-03-23 14:31:38
quoted
I'm hoping that kbuild gets asm-generic support sometime soon so files
with only a "#include <asm-generic/*>" are generated instead of living
in the tree. In that case I'd rather have the non power of 2 constants
added to the generic sizes.h and be done with it. There isn't any strong
technical reason to deny power of 2 constants from the generic header,
right?
No.
I just think that power-of-2 sizes are more generic, not compulsively of course.
Sam Ravnborg had introduced a patch set to provide generic support for
architectures that using one-line asm-generic headers.
It almost ready - but my spare time has been spent on sparc lately.
Will try to take alook at it again soon.
Sam