[PATCH 02/13] plat-spear: use list_move() instead of list_del()/list_add() combination

Subsystems: arm port, the rest

STALE5624d

2 messages, 2 authors, 2011-03-16 · open the first message on its own page

[PATCH 02/13] plat-spear: use list_move() instead of list_del()/list_add() combination

From: Kirill A. Shutemov <hidden>
Date: 2011-03-15 22:53:32

Signed-off-by: Kirill A. Shutemov <redacted>
Cc: Viresh Kumar <redacted>
Cc: Russell King <redacted>
Cc: linux-arm-kernel at lists.infradead.org
---
 arch/arm/plat-spear/clock.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/arch/arm/plat-spear/clock.c b/arch/arm/plat-spear/clock.c
index ee4f90e..1d24faf 100644
--- a/arch/arm/plat-spear/clock.c
+++ b/arch/arm/plat-spear/clock.c
@@ -267,9 +267,7 @@ static void change_parent(struct clk *cclk, struct clk *pclk)
 	unsigned long flags;
 
 	spin_lock_irqsave(&clocks_lock, flags);
-	list_del(&cclk->sibling);
-	list_add(&cclk->sibling, &pclk->children);
-
+	list_move(&cclk->sibling, &pclk->children);
 	cclk->pclk = pclk;
 	spin_unlock_irqrestore(&clocks_lock, flags);
 }
-- 
1.7.4.1

Re: [PATCH 02/13] plat-spear: use list_move() instead of list_del()/list_add() combination

From: viresh kumar <hidden>
Date: 2011-03-16 03:50:29

On 03/16/2011 04:23 AM, Kirill A. Shutemov wrote:
quoted hunk
Signed-off-by: Kirill A. Shutemov <redacted>
Cc: Viresh Kumar <redacted>
Cc: Russell King <redacted>
Cc: linux-arm-kernel at lists.infradead.org
---
 arch/arm/plat-spear/clock.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/arch/arm/plat-spear/clock.c b/arch/arm/plat-spear/clock.c
index ee4f90e..1d24faf 100644
--- a/arch/arm/plat-spear/clock.c
+++ b/arch/arm/plat-spear/clock.c
@@ -267,9 +267,7 @@ static void change_parent(struct clk *cclk, struct clk *pclk)
 	unsigned long flags;
 
 	spin_lock_irqsave(&clocks_lock, flags);
-	list_del(&cclk->sibling);
-	list_add(&cclk->sibling, &pclk->children);
-
+	list_move(&cclk->sibling, &pclk->children);
 	cclk->pclk = pclk;
 	spin_unlock_irqrestore(&clocks_lock, flags);
 }
Acked-by: Viresh Kumar <redacted>

-- 
viresh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help