6 messages, 3 authors, 2011-02-28 · open the first message on its own page
From: Arnaud Patard Rtp <hidden>
Date: 2011-02-28 13:21:32
Hi, With current patches in Sascha Hauer's tree, the efika smartbook is powering off when rebooting. The cause of this bug is the default behaviour of the mc13892 pmic. This patchset is configuring the pmic to reboot the system as expected by imx system.c (the reboot is done throught watchdog) and enables the watchdog on the efika mx/sb systems. Arnaud
From: Arnaud Patard Rtp <hidden>
Date: 2011-02-28 13:21:33
An embedded and charset-unspecified text was scrubbed... Name: mc13892_wdog_reboot.patch URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110228/562257ca/attachment.ksh>
From: Mark Brown <hidden>
Date: 2011-02-28 14:35:52
On Mon, Feb 28, 2011 at 02:21:33PM +0100, Arnaud Patard wrote:
By default, on wdi (watchdog input) event the mc13892 is powering off. This patch is changing this to reboot on wdi event. Signed-off-by: Arnaud Patard <redacted>
This strikes me as something that should be configurable by platforms.
From: Mark Brown <hidden>
Date: 2011-02-28 14:37:41
On Mon, Feb 28, 2011 at 02:21:33PM +0100, Arnaud Patard wrote:
+
+ /* allows to reboot on wdi event */
+ ret = mc13xxx_reg_read(mc13892, MC13892_POWERCTL2, &val);
+ if (!ret) {
+ val |= MC13892_POWERCTL2_WDIRESET;
+ mc13xxx_reg_write(mc13892, MC13892_POWERCTL2, val);
+ }
+Also, why is this in the regulator driver? The MFD core for the device might be a better choice - that'll ensure it gets done even if regulator support isn't enabled for some reason.
From: Arnaud Patard Rtp <hidden>
Date: 2011-02-28 13:21:34
An embedded and charset-unspecified text was scrubbed... Name: wdt.patch URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110228/0e4de70b/attachment.ksh>
From: Uwe Kleine-König <hidden>
Date: 2011-02-28 14:47:45
Hi Arnaud, just one nitpick below ... On Mon, Feb 28, 2011 at 02:21:34PM +0100, Arnaud Patard wrote:
Register watchdog for efika mx and sb systems. Signed-off-by: Arnaud Patard <redacted> Index: linux-2.6-submit/arch/arm/mach-mx5/mx51_efika.c ===================================================================--- linux-2.6-submit.orig/arch/arm/mach-mx5/mx51_efika.c 2011-02-27 23:13:37.000000000 +0100 +++ linux-2.6-submit/arch/arm/mach-mx5/mx51_efika.c 2011-02-27 23:20:38.000000000 +0100@@ -611,6 +611,7 @@ ARRAY_SIZE(mx51efika_pads)); imx51_add_imx_uart(0, &uart_pdata); mx51_efika_usb(); + imx51_add_imx2_wdt(0, NULL); imx51_add_sdhci_esdhc_imx(0, NULL); /* FIXME: comes from original code. check this. */Index: linux-2.6-submit/arch/arm/mach-mx5/Kconfig ===================================================================--- linux-2.6-submit.orig/arch/arm/mach-mx5/Kconfig 2011-02-27 23:13:42.000000000 +0100 +++ linux-2.6-submit/arch/arm/mach-mx5/Kconfig 2011-02-27 23:20:38.000000000 +0100@@ -117,6 +117,7 @@ bool select SOC_IMX51 select IMX_HAVE_PLATFORM_IMX_UART + select IMX_HAVE_PLATFORM_IMX2_WDT select IMX_HAVE_PLATFORM_SDHCI_ESDHC_IMX select IMX_HAVE_PLATFORM_SPI_IMX
These IMX_HAVE_PLATFORM entries are sorted alphabetically and 2 sorts before _, so IMX_HAVE_PLATFORM_IMX2_WDT should be the first entry here. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |