[PATCH] ARM: imx/mach-mx25_3ds: Use IMX_GPIO_NR instead of hard-coded values

Subsystems: arm port, the rest

STALE5641d

3 messages, 3 authors, 2011-02-22 · open the first message on its own page

[PATCH] ARM: imx/mach-mx25_3ds: Use IMX_GPIO_NR instead of hard-coded values

From: Fabio Estevam <hidden>
Date: 2011-02-22 23:24:13

Signed-off-by: Fabio Estevam <redacted>
---
 arch/arm/mach-imx/mach-mx25_3ds.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-imx/mach-mx25_3ds.c b/arch/arm/mach-imx/mach-mx25_3ds.c
index aafc6f7..66b6cdd 100644
--- a/arch/arm/mach-imx/mach-mx25_3ds.c
+++ b/arch/arm/mach-imx/mach-mx25_3ds.c
@@ -109,8 +109,8 @@ static const struct fec_platform_data mx25_fec_pdata __initconst = {
 	.phy    = PHY_INTERFACE_MODE_RMII,
 };
 
-#define FEC_ENABLE_GPIO		35
-#define FEC_RESET_B_GPIO	104
+#define FEC_ENABLE_GPIO		IMX_GPIO_NR(2, 3)
+#define FEC_RESET_B_GPIO	IMX_GPIO_NR(4, 8)
 
 static void __init mx25pdk_fec_reset(void)
 {
-- 
1.6.0.4

Build failure on i.MX25 [Was: [PATCH] ARM: imx/mach-mx25_3ds: Use IMX_GPIO_NR instead of hard-coded values]

From: Uwe Kleine-König <hidden>
Date: 2011-02-22 23:36:10

Hello Fabio,

as you currently seem to work on i.MX25:  My mx25_defconfig our
autobuilder tests each night currently fails on latest linus/master.
You don't happen to already have looked into that?

(I don't have looked either, just want to prevent duplicated work.)

Best regards
Uwe

 

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Build failure on i.MX25 [Was: [PATCH] ARM: imx/mach-mx25_3ds: Use IMX_GPIO_NR instead of hard-coded values]

From: festevam@gmail.com (Fabio Estevam)
Date: 2011-02-22 23:56:30

Hi Uwe,

2011/2/22 Uwe Kleine-K?nig [off-list ref]:
Hello Fabio,

as you currently seem to work on i.MX25: ?My mx25_defconfig our
autobuilder tests each night currently fails on latest linus/master.
You don't happen to already have looked into that?

(I don't have looked either, just want to prevent duplicated work.)
I haven?t looked seen this build isssue yet. Today I built a iMX25
kernel using Sascha?s for-next tree and my own defconfig and this is
probably the reason I haven?t faced this problem.

Thanks,

Fabio Estevam
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help