[PATCH] arm: imx: Zero entire imxdma structure

The semantic match that finds the problem:
// <smpl>
@@
type T;
identifier x;
@@

T *x;
...
* memset(x, ..., ... * sizeof(x) * ...);
// </smpl>

Signed-off-by: Ilia Mirkin <redacted>

---
 arch/arm/mach-imx/dma-v1.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Untested, lack of tool chain and hardware. But there's definitely something
odd going on here, and this seemed like the most logical fix.

diff --git a/arch/arm/mach-imx/dma-v1.c b/arch/arm/mach-imx/dma-v1.c
index e9f1769..236f149 100644
--- a/arch/arm/mach-imx/dma-v1.c
+++ b/arch/arm/mach-imx/dma-v1.c

@@ -699,7 +699,7 @@ int imx_dma_request(int channel, const char *name)
 		local_irq_restore(flags);
 		return -EBUSY;
 	}
-	memset(imxdma, 0, sizeof(imxdma));
+	memset(imxdma, 0, sizeof(*imxdma));
 	imxdma->name = name;
 	local_irq_restore(flags); /* request_irq() can block */
 

-- 
1.7.3.4

On Sun, Feb 20, 2011 at 10:10 PM, Ilia Mirkin [off-list ref] wrote:

The semantic match that finds the problem:
// <smpl>
@@
type T;
identifier x;
@@

T *x;
...
* memset(x, ..., ... * sizeof(x) * ...);
// </smpl>

Signed-off-by: Ilia Mirkin <redacted>

---
?arch/arm/mach-imx/dma-v1.c | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)

Untested, lack of tool chain and hardware. But there's definitely something
odd going on here, and this seemed like the most logical fix.

Doing some quick digging (as I've been discovering that a few of the
other patches I was planning on sending have already been sent out in
the past), I noticed that this same patch was already sent on Dec 9,
2009 by Julia Lawall[1] (back when it was plat-mxc/dma-mx1-mx2.c), and
then again by Vasiliy Kulikov[2] on Oct 10, 2010.

On each occasion, the response was positive, but patch has yet to make
it upstream. Weird.

-- 
Ilia Mirkin
imirkin at alum.mit.edu

[1] Message-ID: [off-list ref]
[2] Message-ID: [off-list ref]

On Sun, Feb 20, 2011 at 10:59:24PM +0000, Ilia Mirkin wrote:

On Sun, Feb 20, 2011 at 10:10 PM, Ilia Mirkin [off-list ref] wrote:

quoted

The semantic match that finds the problem:
// <smpl>
@@
type T;
identifier x;
@@

T *x;
...
* memset(x, ..., ... * sizeof(x) * ...);
// </smpl>

Signed-off-by: Ilia Mirkin <redacted>

---
?arch/arm/mach-imx/dma-v1.c | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)

Untested, lack of tool chain and hardware. But there's definitely something
odd going on here, and this seemed like the most logical fix.

Doing some quick digging (as I've been discovering that a few of the
other patches I was planning on sending have already been sent out in
the past), I noticed that this same patch was already sent on Dec 9,
2009 by Julia Lawall[1] (back when it was plat-mxc/dma-mx1-mx2.c), and
then again by Vasiliy Kulikov[2] on Oct 10, 2010.

On each occasion, the response was positive, but patch has yet to make
it upstream. Weird.

Sascha, are you going to take this patch?

On Sun, Feb 20, 2011 at 11:04:58PM +0000, Russell King - ARM Linux wrote:

On Sun, Feb 20, 2011 at 10:59:24PM +0000, Ilia Mirkin wrote:

quoted

On Sun, Feb 20, 2011 at 10:10 PM, Ilia Mirkin [off-list ref] wrote:

quoted

The semantic match that finds the problem:
// <smpl>
@@
type T;
identifier x;
@@

T *x;
...
* memset(x, ..., ... * sizeof(x) * ...);
// </smpl>

Signed-off-by: Ilia Mirkin <redacted>

---
?arch/arm/mach-imx/dma-v1.c | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)

Untested, lack of tool chain and hardware. But there's definitely something
odd going on here, and this seemed like the most logical fix.

Doing some quick digging (as I've been discovering that a few of the
other patches I was planning on sending have already been sent out in
the past), I noticed that this same patch was already sent on Dec 9,
2009 by Julia Lawall[1] (back when it was plat-mxc/dma-mx1-mx2.c), and
then again by Vasiliy Kulikov[2] on Oct 10, 2010.

On each occasion, the response was positive, but patch has yet to make
it upstream. Weird.

Sascha, are you going to take this patch?

Yes.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |