[PATCH RESEND v6 2/4] TI816X: Update common OMAP machine specific sources

STALE5648d

2 messages, 2 authors, 2011-02-15 · open the first message on its own page

[PATCH RESEND v6 2/4] TI816X: Update common OMAP machine specific sources

From: Kevin Hilman <hidden>
Date: 2011-02-14 23:27:35

Hemant Pedanekar [off-list ref] writes:

[...]
quoted hunk
@@ -402,7 +422,7 @@ void __init omap2_init_common_devices(struct omap_sdrc_params *sdrc_cs0,
 
 	omap_hwmod_late_init();
 
-	if (cpu_is_omap24xx() || cpu_is_omap34xx()) {
+	if (omap3_has_sdrc()) {
 		omap2_sdrc_init(sdrc_cs0, sdrc_cs1);
 		_omap2_init_reprogram_sdrc();
 	}
At first glance, this one doesn't look quite right.  Will 
omap3_has_sdrc()  be true on 24xx?   Please confirm.

Kevin

[PATCH RESEND v6 2/4] TI816X: Update common OMAP machine specific sources

From: Pedanekar, Hemant <hidden>
Date: 2011-02-15 01:09:27

Hilman, Kevin wrote on Tuesday, February 15, 2011 4:58 AM:
Hemant Pedanekar [off-list ref] writes:

[...]
quoted
@@ -402,7 +422,7 @@ void __init
omap2_init_common_devices(struct omap_sdrc_params *sdrc_cs0,
quoted
 	omap_hwmod_late_init();

-	if (cpu_is_omap24xx() || cpu_is_omap34xx()) {
+	if (omap3_has_sdrc()) {
 		omap2_sdrc_init(sdrc_cs0, sdrc_cs1);
 		_omap2_init_reprogram_sdrc();
 	}
At first glance, this one doesn't look quite right.  Will
omap3_has_sdrc()  be true on 24xx?   Please confirm.

Kevin
You are right, this is incorrect as there is no 'features' set for
omap24xx. I will send new version with cpu_is_omap24xx() check retained.

Thanks.
   Hemant
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help