[PATCH] OMAP: IOMMU: add missing function declaration

Subsystems: arm port, the rest

STALE5654d

3 messages, 2 authors, 2011-02-14 · open the first message on its own page

[PATCH] OMAP: IOMMU: add missing function declaration

From: David Cohen <hidden>
Date: 2011-02-12 11:09:47

Function declaration 'iopgtable_lookup_entry' is missing from header
file.

Signed-off-by: David Cohen <redacted>
---
 arch/arm/plat-omap/include/plat/iommu.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/plat-omap/include/plat/iommu.h b/arch/arm/plat-omap/include/plat/iommu.h
index 9e8c104..5a2475f 100644
--- a/arch/arm/plat-omap/include/plat/iommu.h
+++ b/arch/arm/plat-omap/include/plat/iommu.h
@@ -163,6 +163,8 @@ extern void flush_iotlb_range(struct iommu *obj, u32 start, u32 end);
 extern void flush_iotlb_all(struct iommu *obj);
 
 extern int iopgtable_store_entry(struct iommu *obj, struct iotlb_entry *e);
+extern void iopgtable_lookup_entry(struct iommu *obj, u32 da, u32 **ppgd,
+				   u32 **ppte);
 extern size_t iopgtable_clear_entry(struct iommu *obj, u32 iova);
 
 extern int iommu_set_da_range(struct iommu *obj, u32 start, u32 end);
-- 
1.7.1

[PATCH] OMAP: IOMMU: add missing function declaration

From: Varadarajan, Charulatha <hidden>
Date: 2011-02-13 22:36:16

On Sat, Feb 12, 2011 at 19:09, David Cohen [off-list ref] wrote:
Function declaration 'iopgtable_lookup_entry' is missing from header
file.
Is this done because of any error?
You may add a comment on why this is required.
quoted hunk
Signed-off-by: David Cohen <redacted>
---
?arch/arm/plat-omap/include/plat/iommu.h | ? ?2 ++
?1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/plat-omap/include/plat/iommu.h b/arch/arm/plat-omap/include/plat/iommu.h
index 9e8c104..5a2475f 100644
--- a/arch/arm/plat-omap/include/plat/iommu.h
+++ b/arch/arm/plat-omap/include/plat/iommu.h
@@ -163,6 +163,8 @@ extern void flush_iotlb_range(struct iommu *obj, u32 start, u32 end);
?extern void flush_iotlb_all(struct iommu *obj);

?extern int iopgtable_store_entry(struct iommu *obj, struct iotlb_entry *e);
+extern void iopgtable_lookup_entry(struct iommu *obj, u32 da, u32 **ppgd,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?u32 **ppte);
?extern size_t iopgtable_clear_entry(struct iommu *obj, u32 iova);

?extern int iommu_set_da_range(struct iommu *obj, u32 start, u32 end);
--
1.7.1

[PATCH] OMAP: IOMMU: add missing function declaration

From: David Cohen <hidden>
Date: 2011-02-14 11:26:08

On Mon, Feb 14, 2011 at 12:36 AM, Varadarajan, Charulatha [off-list ref] wrote:
On Sat, Feb 12, 2011 at 19:09, David Cohen [off-list ref] wrote:
quoted
Function declaration 'iopgtable_lookup_entry' is missing from header
file.
Is this done because of any error?
You may add a comment on why this is required.
The function is exported by iommu module, but no other driver is using
it so far. So, it's wrong but currently we have only a sparse warning.
I can add this information to the patch description.

Br,

David
quoted
Signed-off-by: David Cohen <redacted>
---
?arch/arm/plat-omap/include/plat/iommu.h | ? ?2 ++
?1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/plat-omap/include/plat/iommu.h b/arch/arm/plat-omap/include/plat/iommu.h
index 9e8c104..5a2475f 100644
--- a/arch/arm/plat-omap/include/plat/iommu.h
+++ b/arch/arm/plat-omap/include/plat/iommu.h
@@ -163,6 +163,8 @@ extern void flush_iotlb_range(struct iommu *obj, u32 start, u32 end);
?extern void flush_iotlb_all(struct iommu *obj);

?extern int iopgtable_store_entry(struct iommu *obj, struct iotlb_entry *e);
+extern void iopgtable_lookup_entry(struct iommu *obj, u32 da, u32 **ppgd,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?u32 **ppte);
?extern size_t iopgtable_clear_entry(struct iommu *obj, u32 iova);

?extern int iommu_set_da_range(struct iommu *obj, u32 start, u32 end);
--
1.7.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help