[PATCH] omap iommu: print module name on error messages

Subsystems: arm port, the rest

STALE5644d

3 messages, 3 authors, 2011-02-17 · open the first message on its own page

[PATCH] omap iommu: print module name on error messages

From: David Cohen <hidden>
Date: 2011-02-12 10:02:29

OMAP IOMMU generic layer doesn't need ot print function name during
error messages. Print module name instead which is more useful.

Signed-off-by: David Cohen <redacted>
---
 arch/arm/plat-omap/iommu.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/plat-omap/iommu.c b/arch/arm/plat-omap/iommu.c
index b1107c0..f55f458 100644
--- a/arch/arm/plat-omap/iommu.c
+++ b/arch/arm/plat-omap/iommu.c
@@ -806,7 +806,7 @@ static irqreturn_t iommu_fault_handler(int irq, void *data)
 	iopgd = iopgd_offset(obj, da);
 
 	if (!iopgd_is_table(*iopgd)) {
-		dev_err(obj->dev, "%s: da:%08x pgd:%p *pgd:%08x\n", __func__,
+		dev_err(obj->dev, "%s: da:%08x pgd:%p *pgd:%08x\n", obj->name,
 			da, iopgd, *iopgd);
 		return IRQ_NONE;
 	}
@@ -814,7 +814,7 @@ static irqreturn_t iommu_fault_handler(int irq, void *data)
 	iopte = iopte_offset(iopgd, da);
 
 	dev_err(obj->dev, "%s: da:%08x pgd:%p *pgd:%08x pte:%p *pte:%08x\n",
-		__func__, da, iopgd, *iopgd, iopte, *iopte);
+		obj->name, da, iopgd, *iopgd, iopte, *iopte);
 
 	return IRQ_NONE;
 }
-- 
1.7.1

[PATCH] omap iommu: print module name on error messages

From: Hiroshi DOYU <hidden>
Date: 2011-02-14 13:41:30

From: ext David Cohen <redacted>
Subject: [PATCH] omap iommu: print module name on error messages
Date: Sat, 12 Feb 2011 12:02:29 +0200
OMAP IOMMU generic layer doesn't need ot print function name during
error messages. Print module name instead which is more useful.
Agree. This makes more sense.
Signed-off-by: David Cohen <redacted>
---
 arch/arm/plat-omap/iommu.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

[PATCH] omap iommu: print module name on error messages

From: tony@atomide.com (Tony Lindgren)
Date: 2011-02-17 23:57:13

* Hiroshi DOYU [off-list ref] [110214 05:39]:
From: ext David Cohen <redacted>
Subject: [PATCH] omap iommu: print module name on error messages
Date: Sat, 12 Feb 2011 12:02:29 +0200
quoted
OMAP IOMMU generic layer doesn't need ot print function name during
error messages. Print module name instead which is more useful.
Agree. This makes more sense.
Applying to devel-iommu-mailbox for the upcoming merge window.

Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help