Currently MMC_MXC driver can be selected by all i.MX devices.
Restrict its use only for the appropriate processors.
Signed-off-by: Fabio Estevam <redacted>
---
drivers/mmc/host/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
On Thu, Jan 20, 2011 at 03:02:59PM -0200, Fabio Estevam wrote:
Currently MMC_MXC driver can be selected by all i.MX devices.
Restrict its use only for the appropriate processors.
Signed-off-by: Fabio Estevam <redacted>
Hallo,
On Thu, Jan 20, 2011 at 03:02:59PM -0200, Fabio Estevam wrote:
quoted hunk
Currently MMC_MXC driver can be selected by all i.MX devices.
Restrict its use only for the appropriate processors.
Signed-off-by: Fabio Estevam <redacted>
---
drivers/mmc/host/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
What about
depends IMX_HAVE_PLATFORM_MXC_MMC
? Then if i.MX29 has the same IP you don't need to touch this again.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Hi Uwe,
On 1/21/2011 1:33 PM, Uwe Kleine-K?nig wrote:
Hallo,
On Thu, Jan 20, 2011 at 03:02:59PM -0200, Fabio Estevam wrote:
quoted
Currently MMC_MXC driver can be selected by all i.MX devices.
Restrict its use only for the appropriate processors.
Signed-off-by: Fabio Estevam <redacted>
---
drivers/mmc/host/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
I would prefer to let the architectures explicitly in Kconfig.
If someone selects IMX_HAVE_PLATFORM_MXC_MMC by mistake on a MX51 board, it will be possible to select the MXC_MMC driver in the kernel for MX51, which is incorrect.
Using the approach of explicitly marking the architectures that support MXC_MMC would avoid such problems as well.
? Then if i.MX29 has the same IP you don't need to touch this again.
Hello Fabio,
On Fri, Jan 21, 2011 at 02:11:46PM -0200, Fabio Estevam wrote:
On 1/21/2011 1:33 PM, Uwe Kleine-K?nig wrote:
quoted
On Thu, Jan 20, 2011 at 03:02:59PM -0200, Fabio Estevam wrote:
quoted
Currently MMC_MXC driver can be selected by all i.MX devices.
Restrict its use only for the appropriate processors.
Signed-off-by: Fabio Estevam <redacted>
---
drivers/mmc/host/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
I would prefer to let the architectures explicitly in Kconfig.
If someone selects IMX_HAVE_PLATFORM_MXC_MMC by mistake on a MX51
board, it will be possible to select the MXC_MMC driver in the kernel
for MX51, which is incorrect.
it's not optimal, but nothing happens unless this someone registers a
corresponding device, too.
Using the approach of explicitly marking the architectures that
support MXC_MMC would avoid such problems as well.
quoted
? Then if i.MX29 has the same IP you don't need to touch this again.
Not likely to happen.
I wouldn't bet ...
Note I don't argue, if you still prefer the explicit list it's OK for
me.
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Chris?
-----Original Message-----
From: Sascha Hauer [mailto:s.hauer at pengutronix.de]
Sent: Friday, January 21, 2011 8:35 AM
To: Estevam Fabio-R49496
Cc: linux-mmc at vger.kernel.org; cjb at laptop.org; kernel at pengutronix.de; u.kleine-koenig at pengutronix.de; linux-arm-kernel at lists.infradead.org
Subject: Re: [PATCH] mmc: mmc_mxc: Allow selection only for the correct platforms
On Thu, Jan 20, 2011 at 03:02:59PM -0200, Fabio Estevam wrote:
Currently MMC_MXC driver can be selected by all i.MX devices.
Restrict its use only for the appropriate processors.
Signed-off-by: Fabio Estevam <redacted>
From: Chris Ball <hidden> Date: 2011-02-09 00:54:52
Hi Fabio,
On Wed, Feb 09, 2011 at 12:40:51AM +0000, Estevam Fabio-R49496 wrote:
On Thu, Jan 20, 2011 at 03:02:59PM -0200, Fabio Estevam wrote:
quoted
Currently MMC_MXC driver can be selected by all i.MX devices.
Restrict its use only for the appropriate processors.
Signed-off-by: Fabio Estevam <redacted>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Thanks for the ping -- I've pushed this to mmc-next with Sascha's ACK now.
--
Chris Ball [off-list ref] <http://printf.net/>
One Laptop Per Child