[PATCH v2] usb: gadget/fsl_mxc_udc: Detect the CPU type in run-time

Subsystems: the rest, usb subsystem

STALE5708d

4 messages, 3 authors, 2011-01-20 · open the first message on its own page

[PATCH v2] usb: gadget/fsl_mxc_udc: Detect the CPU type in run-time

From: Fabio Estevam <hidden>
Date: 2011-01-19 20:17:03

Make sure we are running on a MX35 processor.

Signed-off-by: Fabio Estevam <redacted>
---
 drivers/usb/gadget/fsl_mxc_udc.c |   19 +++++++++++--------
 1 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/gadget/fsl_mxc_udc.c b/drivers/usb/gadget/fsl_mxc_udc.c
index 77b1eb5..c1a65cd 100644
--- a/drivers/usb/gadget/fsl_mxc_udc.c
+++ b/drivers/usb/gadget/fsl_mxc_udc.c
@@ -89,14 +89,17 @@ void fsl_udc_clk_finalize(struct platform_device *pdev)
 {
 	struct fsl_usb2_platform_data *pdata = pdev->dev.platform_data;
 #if defined(CONFIG_ARCH_MX35)
-	unsigned int v;
-
-	/* workaround ENGcm09152 for i.MX35 */
-	if (pdata->workaround & FLS_USB2_WORKAROUND_ENGCM09152) {
-		v = readl(MX35_IO_ADDRESS(MX35_USB_BASE_ADDR +
-				USBPHYCTRL_OTGBASE_OFFSET));
-		writel(v | USBPHYCTRL_EVDO, MX35_IO_ADDRESS(MX35_USB_BASE_ADDR +
-				USBPHYCTRL_OTGBASE_OFFSET));
+	if (cpu_is_mx35()) {
+		unsigned int v;
+
+		/* workaround ENGcm09152 for i.MX35 */
+		if (pdata->workaround & FLS_USB2_WORKAROUND_ENGCM09152) {
+			v = readl(MX35_IO_ADDRESS(MX35_USB_BASE_ADDR +
+					USBPHYCTRL_OTGBASE_OFFSET));
+			writel(v | USBPHYCTRL_EVDO,
+				MX35_IO_ADDRESS(MX35_USB_BASE_ADDR +
+					USBPHYCTRL_OTGBASE_OFFSET));
+		}
 	}
 #endif
 
-- 
1.6.0.4

[PATCH v2] usb: gadget/fsl_mxc_udc: Detect the CPU type in run-time

From: Eric Bénard <hidden>
Date: 2011-01-19 20:41:57

On 19/01/2011 21:17, Fabio Estevam wrote:
Make sure we are running on a MX35 processor.

Signed-off-by: Fabio Estevam<redacted>
Acked-by: Eric B?nard <redacted>
quoted hunk
---
  drivers/usb/gadget/fsl_mxc_udc.c |   19 +++++++++++--------
  1 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/gadget/fsl_mxc_udc.c b/drivers/usb/gadget/fsl_mxc_udc.c
index 77b1eb5..c1a65cd 100644
--- a/drivers/usb/gadget/fsl_mxc_udc.c
+++ b/drivers/usb/gadget/fsl_mxc_udc.c
@@ -89,14 +89,17 @@ void fsl_udc_clk_finalize(struct platform_device *pdev)
  {
  	struct fsl_usb2_platform_data *pdata = pdev->dev.platform_data;
  #if defined(CONFIG_ARCH_MX35)
-	unsigned int v;
-
-	/* workaround ENGcm09152 for i.MX35 */
-	if (pdata->workaround&  FLS_USB2_WORKAROUND_ENGCM09152) {
-		v = readl(MX35_IO_ADDRESS(MX35_USB_BASE_ADDR +
-				USBPHYCTRL_OTGBASE_OFFSET));
-		writel(v | USBPHYCTRL_EVDO, MX35_IO_ADDRESS(MX35_USB_BASE_ADDR +
-				USBPHYCTRL_OTGBASE_OFFSET));
+	if (cpu_is_mx35()) {
+		unsigned int v;
+
+		/* workaround ENGcm09152 for i.MX35 */
+		if (pdata->workaround&  FLS_USB2_WORKAROUND_ENGCM09152) {
+			v = readl(MX35_IO_ADDRESS(MX35_USB_BASE_ADDR +
+					USBPHYCTRL_OTGBASE_OFFSET));
+			writel(v | USBPHYCTRL_EVDO,
+				MX35_IO_ADDRESS(MX35_USB_BASE_ADDR +
+					USBPHYCTRL_OTGBASE_OFFSET));
+		}
  	}
  #endif

[PATCH v2] usb: gadget/fsl_mxc_udc: Detect the CPU type in run-time

From: Uwe Kleine-König <hidden>
Date: 2011-01-19 21:32:51

On Wed, Jan 19, 2011 at 06:17:03PM -0200, Fabio Estevam wrote:
Make sure we are running on a MX35 processor.

Signed-off-by: Fabio Estevam <redacted>
Looks good, Acked-by: Uwe Kleine-K?nig [off-list ref]

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[PATCH v2] usb: gadget/fsl_mxc_udc: Detect the CPU type in run-time

From: Uwe Kleine-König <hidden>
Date: 2011-01-20 08:20:16

On Wed, Jan 19, 2011 at 10:32:51PM +0100, Uwe Kleine-K?nig wrote:
On Wed, Jan 19, 2011 at 06:17:03PM -0200, Fabio Estevam wrote:
quoted
Make sure we are running on a MX35 processor.

Signed-off-by: Fabio Estevam <redacted>
Looks good, Acked-by: Uwe Kleine-K?nig [off-list ref]
looking again s/CONFIG_ARCH_MX35/CONFIG_SOC_IMX35/ would be nice.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help