[PATCH] Fix dmaengine_submit() return type

Subsystems: dma generic offload engine subsystem, the rest

STALE5711d

3 messages, 2 authors, 2011-01-14 · open the first message on its own page

[PATCH] Fix dmaengine_submit() return type

From: Russell King - ARM Linux <hidden>
Date: 2011-01-01 23:00:23 

desc->tx_submit's return type is dma_cookie_t, not int.  Therefore,
dmaengine_submit() should match this return type as it's just
wrapping this detail.

Signed-off-by: Russell King <redacted>
---
 include/linux/dmaengine.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
index 9d8688b..830935b 100644
--- a/include/linux/dmaengine.h
+++ b/include/linux/dmaengine.h
@@ -532,7 +532,7 @@ static inline int dmaengine_resume(struct dma_chan *chan)
 	return dmaengine_device_control(chan, DMA_RESUME, 0);
 }
 
-static inline int dmaengine_submit(struct dma_async_tx_descriptor *desc)
+static inline dma_cookie_t dmaengine_submit(struct dma_async_tx_descriptor *desc)
 {
 	return desc->tx_submit(desc);
 }

[PATCH] Fix dmaengine_submit() return type

From: Russell King - ARM Linux <hidden>
Date: 2011-01-12 10:30:52 

Ping?

On Sat, Jan 01, 2011 at 11:00:23PM +0000, Russell King - ARM Linux wrote:
quoted hunk
desc->tx_submit's return type is dma_cookie_t, not int.  Therefore,
dmaengine_submit() should match this return type as it's just
wrapping this detail.

Signed-off-by: Russell King <redacted>
---
 include/linux/dmaengine.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
index 9d8688b..830935b 100644
--- a/include/linux/dmaengine.h
+++ b/include/linux/dmaengine.h
@@ -532,7 +532,7 @@ static inline int dmaengine_resume(struct dma_chan *chan)
 	return dmaengine_device_control(chan, DMA_RESUME, 0);
 }
 
-static inline int dmaengine_submit(struct dma_async_tx_descriptor *desc)
+static inline dma_cookie_t dmaengine_submit(struct dma_async_tx_descriptor *desc)
 {
 	return desc->tx_submit(desc);
 }

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH] Fix dmaengine_submit() return type

From: Linus Walleij <hidden>
Date: 2011-01-14 15:08:31 

2011/1/2 Russell King - ARM Linux [off-list ref]:
desc->tx_submit's return type is dma_cookie_t, not int. ?Therefore,
dmaengine_submit() should match this return type as it's just
wrapping this detail.

Signed-off-by: Russell King <redacted>
Acked-by: Linus Walleij <redacted>
FWIW

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help