Re: [PATCH 4/4] msm: clock: Add support for more proc_comm clocks

On Tue, Jan 25 2011, Daniel Walker wrote:

On Mon, 2011-01-24 at 19:45 -0800, Stephen Boyd wrote:

quoted

Support the CE_CLK and CODEC_SSBI_CLK. Also add support for uart,
and i2c clocks on targets which support proc_comm clocks.

Basically when you catch yourself writing "also" in the commit text you
need to re-evaluate making two patches.. In this case it looks
appropriate..

Or it is just an argument to not use the word also in the commit text.
I don't think it's really necessary to split up a patch that adds a few
clocks to the clock table.

David

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

On Wed, 2011-01-26 at 14:03 -0800, David Brown wrote:

On Tue, Jan 25 2011, Daniel Walker wrote:

quoted

On Mon, 2011-01-24 at 19:45 -0800, Stephen Boyd wrote:

quoted

Support the CE_CLK and CODEC_SSBI_CLK. Also add support for uart,
and i2c clocks on targets which support proc_comm clocks.

Basically when you catch yourself writing "also" in the commit text you
need to re-evaluate making two patches.. In this case it looks
appropriate..

Or it is just an argument to not use the word also in the commit text.
I don't think it's really necessary to split up a patch that adds a few
clocks to the clock table.

This one it actually makes a lot of sense to break it up. He's doing
some very different things here all in the same patch ..

Daniel


-- 

Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.