FW: [PATCH 05/11] omap3: Remove non-existent config option

 Correction in name

-----Original Message-----
From: Marathe, Yogesh 
Sent: Wednesday, October 06, 2010 2:02 PM
To: Guzman Lugo, Fernando
Cc: Felipe Contreras; Kanigeri, Hari; Premi, Sanjeev; Tony Lindgren; linux-arm-kernel at lists.infradead.org; linux-omap at vger.kernel.org
Subject: RE: [PATCH 05/11] omap3: Remove non-existent config option

-----Original Message-----
From: Guzman Lugo, Fernando
Sent: Wednesday, October 06, 2010 5:44 AM
To: Marathe, Yogesh; Felipe Contreras
Cc: Kanigeri, Hari; Premi, Sanjeev; Tony Lindgren; linux-arm-
kernel at lists.infradead.org; linux-omap at vger.kernel.org
Subject: RE: [PATCH 05/11] omap3: Remove non-existent config
option

quoted

-----Original Message-----
From: linux-omap-owner at vger.kernel.org
[mailto:linux-omap-owner at vger.kernel.org] On Behalf Of Marathe,

Yogesh

quoted

Sent: Friday, October 01, 2010 6:29 AM
To: Felipe Contreras
Cc: Kanigeri, Hari; Premi, Sanjeev; Tony Lindgren;
linux-arm-kernel at lists.infradead.org; linux-omap at vger.kernel.org
Subject: RE: [PATCH 05/11] omap3: Remove non-existent config

option

quoted

quoted

-----Original Message-----
From: Felipe Contreras [mailto:felipe.contreras at gmail.com]
Sent: Thursday, September 30, 2010 12:42 AM
To: Marathe, Yogesh
Cc: Kanigeri, Hari; Premi, Sanjeev; Tony Lindgren; linux-arm-
kernel at lists.infradead.org; linux-omap at vger.kernel.org
Subject: Re: [PATCH 05/11] omap3: Remove non-existent config

option

quoted

quoted

On Wed, Sep 29, 2010 at 4:28 PM, Marathe, Yogesh
[off-list ref] wrote:

quoted

dsplink and syslink (two drivers who use iommu) should not

enable

quoted

quoted

quoted

CONFIG_MPU_BRIDGE_IOMMU as dspbridge and dsplink

/syslink can not

quoted

quoted

quoted

co-exist as they are using same resources. Not applying

patch

quoted

breaks dsplink/sylink any one which is being used. Defining this

config

quoted

makes them co-exist.

No, for dsp-link you would have:
CONFIG_TIDSPBRIDGE=n
CONFIG_OMAP_IOMMU_IVA2=y

It would be exactly the same as applying your patch.

And tidspbridge is not using iommu right now.

I noticed that you have added OMAP_IOMMU_IVA2 to Kconfig. In
this case I need CONFIG_OMAP_IOMMU_IVA2=y by default on
master so that iommu is open to use for all other drivers by default.

quoted

And AFAIK syslink is not for omap3, so omap3_devices is not

relevant.

quoted

quoted

I'm ok with changing name to CONFIG_OMAP_IOMMU_IVA2

but

quoted

quoted

ideally

quoted

then that will also break the dspbridge.

No, grep for MPU_BRIDGE_IOMMU on the current tidspbridge in

mainline;

quoted

it's not defined anywhere, so CONFIG_OMAP_IOMMU_IVA2, or
CONFIG_FOOBAR, it doesn't matter for tidspbridge right now. And
MPU_BRIDGE_IOMMU doesn't depend on tidspbridge on any way.

Please explain, how removing CONFIG_MPU_BRIDGE_IOMMU Or

any

quoted

other the config name in place, breaks tidspbridge?
My patch is removing the 'if defined'.

Can I know the status of this patch?

I have been discussing this with Felipe. In his opinion we should have 
a Kconfig option and iommu user should explicitly set it to 'y' if they wish
to use it. I'm saying removal of this 'if defined' solves the problem which
is what you also want.

This patch is needed now that tidspbridge has migrated to use
Iommu moudle.

Will this patch be merged?

I'm also waiting on this patch to get accepted.

Regards,
Fernando.

quoted

quoted

quoted

One more way would be to soure revert the patch and apply on

dspbridge branch if it breaks the builds on that branch rather than

quoted

breaking others in master.

There is no tidspbrige branch; it's in mainline:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-
2.6.git;a=tree;f=drivers/staging/tidspbridge

But that doesn't matter, even if it was in a branch, iommu

should not

quoted

break either tidspbridge, or dsp-link, and driver branches

should not

quoted

modify anything outside their domain (ideally).

All you need to do is 'select OMAP_IOMMU_IVA2', although

the attached

quoted

patch would be needed.

--
Felipe Contreras

--
To unsubscribe from this list: send the line "unsubscribe
linux-omap" in the body of a message to
majordomo at vger.kernel.org More majordomo info at
http://vger.kernel.org/majordomo-info.html

Regards,
Yogesh.