[PATCH 5/5] ASoc: add machine driver for 88pm860x

STALE5912d

4 messages, 2 authors, 2010-08-13 · open the first message on its own page

[PATCH 5/5] ASoc: add machine driver for 88pm860x

From: haojian.zhuang@gmail.com (Haojian Zhuang)
Date: 2010-08-13 13:55:53

(no body)

[PATCH 5/5] ASoc: add machine driver for 88pm860x

From: Mark Brown <hidden>
Date: 2010-08-13 14:26:46 

On Fri, Aug 13, 2010 at 09:55:53PM +0800, Haojian Zhuang wrote:
From cd2063f68b233a86b24efa3f4dc3ca3c438b1576 Mon Sep 17 00:00:00 2001
From: Haojian Zhuang <redacted>
Date: Thu, 12 Aug 2010 12:04:23 +0800
Please fix your configuration for sending patches - none of this header
stuff should be in the body of the mail.

Subject: [PATCH 5/5] ASoc: add machine driver for 88pm860x
It's not a machine driver for this CODEC, it appears to be two machine
drivers for...

88PM860x codec is used in Marvell development board (Saarb and tavorevb3).
Codec is used as master mode in both of these two boards.
...these two boards.  I'd suggest supplying one board per patch.

+#include "../../arm/pxa2xx-pcm.h"
Why?
quoted hunk
+	SND_SOC_DAPM_SPK("Board Speaker", NULL),
+	SND_SOC_DAPM_MIC("Board Mic 1", NULL),
+	SND_SOC_DAPM_MIC("Board Mic 3", NULL),
What happened to Mic 2?

[PATCH 5/5] ASoc: add machine driver for 88pm860x

From: haojian.zhuang@gmail.com (Haojian Zhuang)
Date: 2010-08-13 15:01:36 

On Fri, Aug 13, 2010 at 10:26 PM, Mark Brown
[off-list ref] wrote:
On Fri, Aug 13, 2010 at 09:55:53PM +0800, Haojian Zhuang wrote:
quoted
From cd2063f68b233a86b24efa3f4dc3ca3c438b1576 Mon Sep 17 00:00:00 2001
From: Haojian Zhuang <redacted>
Date: Thu, 12 Aug 2010 12:04:23 +0800
Please fix your configuration for sending patches - none of this header
stuff should be in the body of the mail.
Oh. It seems wrong date. Do you know how to resolve this?
quoted
Subject: [PATCH 5/5] ASoc: add machine driver for 88pm860x
It's not a machine driver for this CODEC, it appears to be two machine
drivers for...
quoted
88PM860x codec is used in Marvell development board (Saarb and tavorevb3).
Codec is used as master mode in both of these two boards.
...these two boards. ?I'd suggest supplying one board per patch.
OK
quoted
+#include "../../arm/pxa2xx-pcm.h"
Why?
should remove
quoted
+ ? ? SND_SOC_DAPM_SPK("Board Speaker", NULL),
+ ? ? SND_SOC_DAPM_MIC("Board Mic 1", NULL),
+ ? ? SND_SOC_DAPM_MIC("Board Mic 3", NULL),
What happened to Mic 2?
Mic 2 is in headset. I declared it with "Mic Jack" in DAPM.

[PATCH 5/5] ASoc: add machine driver for 88pm860x

From: Mark Brown <hidden>
Date: 2010-08-13 15:17:44 

On Fri, Aug 13, 2010 at 11:01:36PM +0800, Haojian Zhuang wrote:
On Fri, Aug 13, 2010 at 10:26 PM, Mark Brown
quoted
quoted
From cd2063f68b233a86b24efa3f4dc3ca3c438b1576 Mon Sep 17 00:00:00 2001
From: Haojian Zhuang <redacted>
Date: Thu, 12 Aug 2010 12:04:23 +0800
quoted
Please fix your configuration for sending patches - none of this header
stuff should be in the body of the mail.
Oh. It seems wrong date. Do you know how to resolve this?
Using git send-email to send patches is the easiest thing, if you're
copying into the body of the message then just dropping this block from
the patch when you're pasting it in will usually do the trick.

quoted
quoted
+ ? ? SND_SOC_DAPM_SPK("Board Speaker", NULL),
+ ? ? SND_SOC_DAPM_MIC("Board Mic 1", NULL),
+ ? ? SND_SOC_DAPM_MIC("Board Mic 3", NULL),
quoted
What happened to Mic 2?
Mic 2 is in headset. I declared it with "Mic Jack" in DAPM.
Ah, OK.  Might be clearer if you said something more like:

+ ? ? SND_SOC_DAPM_MIC("Board Mic 1", NULL),
+ ? ? SND_SOC_DAPM_MIC("Mic Jack", NULL),
+ ? ? SND_SOC_DAPM_MIC("Board Mic 3", NULL),

so it's easier to work out where the second jack went.




    
  

  
    

      

        Keyboard shortcuts
      

      

        
          
hback out one level

          
jnext message in thread

          
kprevious message in thread

          
ldrill in

          
Escclose help / fold thread tree

          
?toggle this help