[PATCH] fix GDB_MAX_REGS not defined in arch/arm/kernel/kgdb.c

Subsystems: arm port, the rest

STALE5915d

2 messages, 1 author, 2010-08-12 · open the first message on its own page

[PATCH] fix GDB_MAX_REGS not defined in arch/arm/kernel/kgdb.c

From: eric.y.miao at gmail.com <hidden>
Date: 2010-08-09 02:03:25

How about this?

Signed-off-by: Eric Miao <redacted>
diff --git a/arch/arm/kernel/kgdb.c b/arch/arm/kernel/kgdb.c
index 778c2f7..d6e8b4d 100644
--- a/arch/arm/kernel/kgdb.c
+++ b/arch/arm/kernel/kgdb.c
@@ -79,7 +79,7 @@ sleeping_thread_to_gdb_regs(unsigned long *gdb_regs,
struct task_struct *task)
 		return;

 	/* Initialize to zero */
-	for (regno = 0; regno < GDB_MAX_REGS; regno++)
+	for (regno = 0; regno < DBG_MAX_REG_NUM; regno++)
 		gdb_regs[regno] = 0;

 	/* Otherwise, we have only some registers from switch_to() */

[PATCH] fix GDB_MAX_REGS not defined in arch/arm/kernel/kgdb.c

From: Eric Miao <hidden>
Date: 2010-08-12 13:56:49

Cc'ed Jason.

Now it looks like this is caused by an incomplete change of commit:

22eeef4b kgdb,arm: Individual register get/set for arm

Russell,

Will submit the patch to your tracking system later.

On Mon, Aug 9, 2010 at 10:03 AM, eric.y.miao at gmail.com
[off-list ref] wrote:
quoted hunk
How about this?

Signed-off-by: Eric Miao <redacted>
diff --git a/arch/arm/kernel/kgdb.c b/arch/arm/kernel/kgdb.c
index 778c2f7..d6e8b4d 100644
--- a/arch/arm/kernel/kgdb.c
+++ b/arch/arm/kernel/kgdb.c
@@ -79,7 +79,7 @@ sleeping_thread_to_gdb_regs(unsigned long *gdb_regs,
struct task_struct *task)
? ? ? ? ? ? ? ?return;

? ? ? ?/* Initialize to zero */
- ? ? ? for (regno = 0; regno < GDB_MAX_REGS; regno++)
+ ? ? ? for (regno = 0; regno < DBG_MAX_REG_NUM; regno++)
? ? ? ? ? ? ? ?gdb_regs[regno] = 0;

? ? ? ?/* Otherwise, we have only some registers from switch_to() */
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help