[PATCH 2/7] wire up sys_time_change_notify() on ARM

Subsystems: arm port, the rest

STALE5892d

3 messages, 3 authors, 2010-09-01 · open the first message on its own page

[PATCH 2/7] wire up sys_time_change_notify() on ARM

From: Alexander Shishkin <hidden>
Date: 2010-08-31 11:47:30

sys_time_change_notify() is a new syscall with number and types of
parameters such that no ARM-specific processing is needed.

Tested with 2.6.36-rc3 using Documentation/time-change-notify-example.c.

Signed-off-by: Alexander Shishkin <redacted>
CC: Russell King <redacted>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: David Howells <dhowells@redhat.com>
CC: Christoph Hellwig <hch@lst.de>
CC: "H. Peter Anvin" <hpa@zytor.com>
CC: linux-arm-kernel at lists.infradead.org
CC: linux-kernel at vger.kernel.org
---
 arch/arm/include/asm/unistd.h |    1 +
 arch/arm/kernel/calls.S       |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/include/asm/unistd.h b/arch/arm/include/asm/unistd.h
index d02cfb6..ce38a6f 100644
--- a/arch/arm/include/asm/unistd.h
+++ b/arch/arm/include/asm/unistd.h
@@ -393,6 +393,7 @@
 #define __NR_perf_event_open		(__NR_SYSCALL_BASE+364)
 #define __NR_recvmmsg			(__NR_SYSCALL_BASE+365)
 #define __NR_accept4			(__NR_SYSCALL_BASE+366)
+#define __NR_time_change_notify		(__NR_SYSCALL_BASE+367)
 
 /*
  * The following SWIs are ARM private.
diff --git a/arch/arm/kernel/calls.S b/arch/arm/kernel/calls.S
index afeb71f..f1e64ba 100644
--- a/arch/arm/kernel/calls.S
+++ b/arch/arm/kernel/calls.S
@@ -376,6 +376,7 @@
 		CALL(sys_perf_event_open)
 /* 365 */	CALL(sys_recvmmsg)
 		CALL(sys_accept4)
+		CALL(sys_time_change_notify)
 #ifndef syscalls_counted
 .equ syscalls_padding, ((NR_syscalls + 3) & ~3) - NR_syscalls
 #define syscalls_counted
-- 
1.7.1

Re: [PATCH 2/7] wire up sys_time_change_notify() on ARM

From: Mikael Pettersson <hidden>
Date: 2010-08-31 12:37:53

Alexander Shishkin writes:
 > sys_time_change_notify() is a new syscall with number and types of
 > parameters such that no ARM-specific processing is needed.
 > 
 > Tested with 2.6.36-rc3 using Documentation/time-change-notify-example.c.
 > 
 > Signed-off-by: Alexander Shishkin [off-list ref]
 > CC: Russell King [off-list ref]
 > CC: Andrew Morton [off-list ref]
 > CC: David Howells [off-list ref]
 > CC: Christoph Hellwig [off-list ref]
 > CC: "H. Peter Anvin" [off-list ref]
 > CC: linux-arm-kernel at lists.infradead.org
 > CC: linux-kernel at vger.kernel.org
 > ---
 >  arch/arm/include/asm/unistd.h |    1 +
 >  arch/arm/kernel/calls.S       |    1 +
 >  2 files changed, 2 insertions(+), 0 deletions(-)
 > 
 > diff --git a/arch/arm/include/asm/unistd.h b/arch/arm/include/asm/unistd.h
 > index d02cfb6..ce38a6f 100644
 > --- a/arch/arm/include/asm/unistd.h
 > +++ b/arch/arm/include/asm/unistd.h
 > @@ -393,6 +393,7 @@
 >  #define __NR_perf_event_open		(__NR_SYSCALL_BASE+364)
 >  #define __NR_recvmmsg			(__NR_SYSCALL_BASE+365)
 >  #define __NR_accept4			(__NR_SYSCALL_BASE+366)
 > +#define __NR_time_change_notify		(__NR_SYSCALL_BASE+367)
 >  
 >  /*
 >   * The following SWIs are ARM private.
 > diff --git a/arch/arm/kernel/calls.S b/arch/arm/kernel/calls.S
 > index afeb71f..f1e64ba 100644
 > --- a/arch/arm/kernel/calls.S
 > +++ b/arch/arm/kernel/calls.S
 > @@ -376,6 +376,7 @@
 >  		CALL(sys_perf_event_open)
 >  /* 365 */	CALL(sys_recvmmsg)
 >  		CALL(sys_accept4)
 > +		CALL(sys_time_change_notify)
 >  #ifndef syscalls_counted
 >  .equ syscalls_padding, ((NR_syscalls + 3) & ~3) - NR_syscalls
 >  #define syscalls_counted

No, you need to use 370 as the syscall number on ARM as 367-369
have been assigned to the fanotify and prlimit64 syscalls; see

http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=6343/1

/Mikael

Re: [PATCH 2/7] wire up sys_time_change_notify() on ARM

From: Russell King - ARM Linux <hidden>
Date: 2010-09-01 09:15:59

On Tue, Aug 31, 2010 at 02:45:46PM +0300, Alexander Shishkin wrote:
sys_time_change_notify() is a new syscall with number and types of
parameters such that no ARM-specific processing is needed.
This patch needs to be redone.  Please wait until I've finished catching
up with the last 10 or so days of email and merged my tree into mainline.
Alternatively, update your patch to apply on top of my master branch.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help