DORMANTno replies REVIEWED: 1 (0M)

1 review trailer.

[PATCH] nhk8815: fix i2c-gpio initialization

From: Alessandro Rubini <hidden>
Date: 2009-12-17 09:34:34
Subsystem: arm port, arm/nomadik/ux500 architectures, the rest · Maintainers: Russell King, Linus Walleij, Linus Torvalds

From: Alessandro Rubini <redacted>

Signed-off-by: Alessandro Rubini <redacted>
Acked-by: Andrea Gallo <redacted>
---
 arch/arm/mach-nomadik/i2c-8815nhk.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-nomadik/i2c-8815nhk.c b/arch/arm/mach-nomadik/i2c-8815nhk.c
index abfe25a..7045ec1 100644
--- a/arch/arm/mach-nomadik/i2c-8815nhk.c
+++ b/arch/arm/mach-nomadik/i2c-8815nhk.c
@@ -43,12 +43,17 @@ static struct platform_device nhk8815_i2c_dev1 = {
 
 static int __init nhk8815_i2c_init(void)
 {
+	/* i2c-gpio switches from out to in and back, so force out data to 0 */
 	nmk_gpio_set_mode(nhk8815_i2c_data0.scl_pin, NMK_GPIO_ALT_GPIO);
 	nmk_gpio_set_mode(nhk8815_i2c_data0.sda_pin, NMK_GPIO_ALT_GPIO);
+	gpio_set_value(nhk8815_i2c_data0.sda_pin, 0);
+	gpio_set_value(nhk8815_i2c_data0.scl_pin, 0);
 	platform_device_register(&nhk8815_i2c_dev0);
 
 	nmk_gpio_set_mode(nhk8815_i2c_data1.scl_pin, NMK_GPIO_ALT_GPIO);
 	nmk_gpio_set_mode(nhk8815_i2c_data1.sda_pin, NMK_GPIO_ALT_GPIO);
+	gpio_set_value(nhk8815_i2c_data1.sda_pin, 0);
+	gpio_set_value(nhk8815_i2c_data1.scl_pin, 0);
 	platform_device_register(&nhk8815_i2c_dev1);
 
 	return 0;
-- 
1.6.0.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help