Re: [PATCH 14/20] exit/syscall_user_dispatch: Send ordinary signals on failure

Kees Cook [off-list ref] writes:

On Wed, Oct 20, 2021 at 12:44:00PM -0500, Eric W. Biederman wrote:

quoted

Use force_fatal_sig instead of calling do_exit directly.  This ensures
the ordinary signal handling path gets invoked, core dumps as
appropriate get created, and for multi-threaded processes all of the
threads are terminated not just a single thread.

Yeah, looks good. Should be no visible behavior change.

It is observable in that an entire multi-threaded process gets
terminated instead of a single thread.  But since these events should
be handling of extra-ordinary events I don't expect there is anyone
who wants to have a thread of their process survive.

Eric

On Thu, Oct 21, 2021 at 11:37:23AM -0500, Eric W. Biederman wrote:

Kees Cook [off-list ref] writes:

quoted

On Wed, Oct 20, 2021 at 12:44:00PM -0500, Eric W. Biederman wrote:

quoted

Use force_fatal_sig instead of calling do_exit directly.  This ensures
the ordinary signal handling path gets invoked, core dumps as
appropriate get created, and for multi-threaded processes all of the
threads are terminated not just a single thread.

Yeah, looks good. Should be no visible behavior change.

It is observable in that an entire multi-threaded process gets
terminated instead of a single thread.  But since these events should
be handling of extra-ordinary events I don't expect there is anyone
who wants to have a thread of their process survive.

Right -- sorry, I should have said that more clearly: "Besides the
single thread death now taking the whole process, there's not behavior
change (i.e. the signal delivery)." Still looks good to me.

-- 
Kees Cook