# Re: \[PATCH 16/20\] signal/sparc32: In setup\_rt\_frame and setup\_fram use force\_fatal\_sig

- From: Kees Cook \<hidden\>
- Date: 2021-10-21 16:35:02 
- List: linux-arch
- Page: https://ratatoskr.run/linux-arch/2021/10/1549903
- Thread: https://ratatoskr.run/linux-arch/2021/10/1548606/t.md

```text
On Wed, Oct 20, 2021 at 12:44:02PM -0500, Eric W. Biederman wrote:
> Modify the 32bit version of setup_rt_frame and setup_frame to act
> similar to the 64bit version of setup_rt_frame and fail with a signal
> instead of calling do_exit.
> 
> Replacing do_exit(SIGILL) with force_fatal_signal(SIGILL) ensures that
> the process will be terminated cleanly when the stack frame is
> invalid, instead of just killing off a single thread and leaving the
> process is a weird state.
> 
> Cc: David Miller <davem@davemloft.net>
> Cc: <redacted>
> Signed-off-by: Eric W. Biederman <redacted>

Nicely already had the return path written. :)

Reviewed-by: Kees Cook <redacted>

-- 
Kees Cook
```
