# Re: \[PATCH 17/17\] vsprintf: rework bitmap\_list\_string

- From: Petr Mladek \<pmladek@suse.com\>
- Date: 2021-08-26 14:15:16 
- List: linux-arch
- Page: https://ratatoskr.run/linux-arch/2021/08/1489749
- Thread: https://ratatoskr.run/linux-mm/2021/08/1477967/t.md

```text
On Sat 2021-08-14 14:17:13, Yury Norov wrote:
> bitmap_list_string() is very ineffective when printing bitmaps with long
> ranges of set bits because it calls find_next_bit for each bit in the
> bitmap.  We can do better by detecting ranges of set bits.
> 
> In my environment, before/after is 943008/31008 ns.
> 
> Signed-off-by: Yury Norov <yury.norov@gmail.com>
> Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

I like the patch. The new code is much easier to follow.
Feel free to use:

Reviewed-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr
```