# Re: \[PATCH v2 2/7\] sched: Introduce task\_is\_running()

- From: Peter Zijlstra \<peterz@infradead.org\>
- Date: 2021-06-11 09:17:24 
- List: linux-arch
- Page: https://ratatoskr.run/linux-arch/2021/06/1411037
- Thread: https://ratatoskr.run/linux-arch/2021/06/1410961/t.md

```text
On Fri, Jun 11, 2021 at 10:49:56AM +0200, Geert Uytterhoeven wrote:
> Hoi Peter,
> 
> Thanks for your patch!
> 
> On Fri, Jun 11, 2021 at 10:36 AM Peter Zijlstra [ref] wrote:
> > Replace a bunch of 'p->state == TASK_RUNNING' with a new helper:
> > task_is_running(p).
> 
> You're also sticking a READ_ONCE() in the helper, which wasn't done
> by any of the old implementations? Care to mention why?

Patch 7/7 should clarify. Arguably I should leave the READ_ONCE() off
here and only add it there.


```
