# Re: \[PATCH v3 3/3\] gpio: xilinx: Utilize generic bitmap\_get\_value and \_set\_value

- From: Andy Shevchenko \<hidden\>
- Date: 2021-03-26 18:02:58 
- List: linux-arch
- Page: https://ratatoskr.run/linux-arch/2021/03/6317035
- Thread: https://ratatoskr.run/linux-arch/2021/03/6290883/t.md

```text
On Sat, Mar 6, 2021 at 4:08 PM Syed Nayyar Waris [ref] wrote:

> +       bitmap_set_value(old, 64, state[0], 32, 0);
> +       bitmap_set_value(old, 64, state[1], 32, 32);

Isn't it effectively bitnap_from_arr32() ?

> +       bitmap_set_value(new, 64, state[0], 32, 0);
> +       bitmap_set_value(new, 64, state[1], 32, 32);

Ditto.

-- 
With Best Regards,
Andy Shevchenko
```
