# Re: \[PATCH 08/30\] compat: Use COMPAT\_USE\_64BIT\_TIME in the lp driver

- From: Linus Torvalds \<torvalds@linux-foundation.org\>
- Date: 2012-02-20 00:56:34 
- List: linux-arch
- Page: https://ratatoskr.run/linux-arch/2012/02/3824410
- Thread: https://ratatoskr.run/linux-arch/2012/02/3824368/t.md

```text
On Sun, Feb 19, 2012 at 4:07 PM, H. Peter Anvin [ref] wrote:
> From: "H. J. Lu" <redacted>
>
> Enable the lp driver to be used with a compat ABI with 64-bit time.

Ugh. Is this really the only case?

Because if it isn't, I suspect it would be much better off with a
helper function. In fact, even if this *does* end up being the only
place, a helper function to get/set a timeval from user space sounds
like a good idea, and makes things much more readable than that
ad-hoccery in the middle of code.

IOW, I'd like to see something like

   get_user_timeval(void __user *tv, struct timeval *res)

even if it would be only local to this file.

                   Linus
```
