# Re: \[PATCH 21/40\] OpenRISC: Don't reimplement force\_sigsegv() - From: Jonas Bonn \ - Date: 2012-02-15 16:03:00 - List: linux-arch - Page: https://ratatoskr.run/linux-arch/2012/02/3822806 - Thread: https://ratatoskr.run/linux-arch/2012/02/3822231/t.md ```text Acked-by: Jonas Bonn ...for OpenRISC, all 4 patches (20-23 in this series). Should I take these in the OpenRISC tree or how did you want to do? /Jonas On Tue, 2012-02-14 at 11:40 +0000, Matt Fleming wrote: > From: Matt Fleming > > Instead of open coding the sequence from force_sigsegv() just call > it. This also fixes a bug because we were modifying ka->sa.sa_handler > (which is a copy of sighand->action[]), whereas the intention of the > code was to modify sighand->action[] directly. > > As the original code was working with a copy it had no effect on > signal delivery. > > Acked-by: Oleg Nesterov > Cc: Jonas Bonn > Cc: Arnd Bergmann > Cc: > Signed-off-by: Matt Fleming > --- > arch/openrisc/kernel/signal.c | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/arch/openrisc/kernel/signal.c b/arch/openrisc/kernel/signal.c > index 95207ab..53741ba 100644 > --- a/arch/openrisc/kernel/signal.c > +++ b/arch/openrisc/kernel/signal.c > @@ -250,9 +250,7 @@ static void setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info, > return; > > give_sigsegv: > - if (sig == SIGSEGV) > - ka->sa.sa_handler = SIG_DFL; > - force_sig(SIGSEGV, current); > + force_sigsegv(sig, current); > } > > static inline void -- Jonas Bonn South Pole AB Phone : +46-8-56237100 Anderstorpsvägen 16 Mobile: +46-768-527755 SE-17154 Solna jonas@southpole.se www.southpoleconsulting.com _______________________________________________ Linux mailing list Linux@lists.openrisc.net http://lists.openrisc.net/listinfo/linux ```