Re: signal-race-fix.patch
From: David S. Miller <hidden>
Date: 2004-03-19 22:13:05
From: David S. Miller <hidden>
Date: 2004-03-19 22:13:05
On Fri, 19 Mar 2004 12:01:51 -0800 Andrew Morton [off-list ref] wrote:
We have an SMP race in the signal code. A fix for x86 is below. All archs need updating.
I think the fix may need fixing :-) Now that we're passing a stack local k_sigaction into handle_signal() the real sigaction is not being updated f.e. when SA_ONESHOT causes ka->sa.sa_handler to be set to SIG_DFL. Only the stack local copy is going to be set like this, not the one in the signals struct which is where it is needed. I noticed this while coding up the sparc versions which I'll defer until this is cleared up.