Inter-revision diff: patch 3

Comparing v18 (message) to v23 (message)

--- v18
+++ v23
@@ -6,16 +6,17 @@
 IBT state machine is described in Intel SDM Vol. 1, Sec. 18.3.
 
 Signed-off-by: Yu-cheng Yu <yu-cheng.yu@intel.com>
+Reviewed-by: Kees Cook <keescook@chromium.org>
 ---
- arch/x86/kernel/cet.c        | 27 +++++++++++++++++++++++++--
+ arch/x86/kernel/cet.c        | 26 ++++++++++++++++++++++++--
  arch/x86/kernel/fpu/signal.c |  8 +++++---
- 2 files changed, 30 insertions(+), 5 deletions(-)
+ 2 files changed, 29 insertions(+), 5 deletions(-)
 
 diff --git a/arch/x86/kernel/cet.c b/arch/x86/kernel/cet.c
-index fff0b35ed0d9..68d602aecb1c 100644
+index 3361706ba950..34a26eb7f259 100644
 --- a/arch/x86/kernel/cet.c
 +++ b/arch/x86/kernel/cet.c
-@@ -295,6 +295,13 @@ void cet_restore_signal(struct sc_ext *sc_ext)
+@@ -300,6 +300,13 @@ void cet_restore_signal(struct sc_ext *sc_ext)
  		msr_val |= CET_SHSTK_EN;
  	}
  
@@ -29,13 +30,12 @@
  	if (test_thread_flag(TIF_NEED_FPU_LOAD))
  		cet_user_state->user_cet = msr_val;
  	else
-@@ -335,9 +342,25 @@ int cet_setup_signal(bool ia32, unsigned long rstor_addr, struct sc_ext *sc_ext)
+@@ -340,9 +347,24 @@ int cet_setup_signal(bool ia32, unsigned long rstor_addr, struct sc_ext *sc_ext)
  		sc_ext->ssp = new_ssp;
  	}
  
 -	if (ssp) {
 +	if (ssp || cet->ibt_enabled) {
-+
  		start_update_msrs();
 -		wrmsrl(MSR_IA32_PL3_SSP, ssp);
 +
@@ -58,7 +58,7 @@
  	}
  
 diff --git a/arch/x86/kernel/fpu/signal.c b/arch/x86/kernel/fpu/signal.c
-index c0c2141cb4b3..077853ef6f48 100644
+index 270e4649f435..b914d74c8ba6 100644
 --- a/arch/x86/kernel/fpu/signal.c
 +++ b/arch/x86/kernel/fpu/signal.c
 @@ -57,7 +57,8 @@ int save_cet_to_sigframe(int ia32, void __user *fp, unsigned long restorer)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help