# Re: \[PATCH v6 4/6\] fs: make vfs\_fileattr\_\[get\|set\] return -EOPNOSUPP

- From: Jan Kara \<jack@suse.cz\>
- Date: 2025-07-01 12:53:03 
- List: linux-api
- Page: https://ratatoskr.run/linux-api/2025/07/316450
- Thread: https://ratatoskr.run/linux-api/2025/06/316331/t.md

```text
On Mon 30-06-25 18:20:14, Andrey Albershteyn wrote:
> Future patches will add new syscalls which use these functions. As
> this interface won't be used for ioctls only, the EOPNOSUPP is more
> appropriate return code.
> 
> This patch converts return code from ENOIOCTLCMD to EOPNOSUPP for
> vfs_fileattr_get and vfs_fileattr_set. To save old behavior translate
> EOPNOSUPP back for current users - overlayfs, encryptfs and fs/ioctl.c.
> 
> Signed-off-by: Andrey Albershteyn <aalbersh@kernel.org>

Modulo the small nits already pointed out this looks good to me. Feel free
to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza
-- 
Jan Kara [ref]
SUSE Labs, CR
```