# Re: \[PATCH 1/2\] ptrace: Move setting/clearing ptrace\_message into ptrace\_stop

- From: Kees Cook \<hidden\>
- Date: 2022-03-17 19:10:22 
- List: linux-api
- Page: https://ratatoskr.run/linux-api/2022/03/1708443
- Thread: https://ratatoskr.run/linux-api/2022/03/1706070/t.md

```text
On Tue, Mar 15, 2022 at 06:21:08PM -0500, Eric W. Biederman wrote:
> 
> Today ptrace_message is easy to overlook as it not a core part of
> ptrace_stop.  It has been overlooked so much that there are places
> that set ptrace_message and don't clear it, and places that never set
> it.  So if you get an unlucky sequence of events the ptracer may be
> able to read a ptrace_message that does not apply to the current
> ptrace stop.
> 
> Move setting of ptrace_message into ptrace_stop so that it always gets
> set before the stop, and always gets cleared after the stop.  This
> prevents non-sense from being reported to userspace and makes
> ptrace_message more visible in the ptrace helper functions so that
> kernel developers can see it.
> 
> Signed-off-by: "Eric W. Biederman" <redacted>

This looks good to me. Did you happen to run the seccomp selftests
before/after these changes?

Reviewed-by: Kees Cook <redacted>

-- 
Kees Cook
```
