# Re: \[PATCH v2 1/3\] block: simplify calling convention of elv\_unregister\_queue()

- From: Hannes Reinecke \<hare@suse.de\>
- Date: 2021-11-30 06:44:53 
- List: linux-api
- Page: https://ratatoskr.run/linux-api/2021/11/1590895
- Thread: https://ratatoskr.run/linux-block/2021/11/1590823/t.md

```text
On 11/30/21 5:03 AM, Eric Biggers wrote:
> From: Eric Biggers <redacted>
>
> Make elv_unregister_queue() a no-op if q->elevator is NULL or is not
> registered.
>
> This simplifies the existing callers, as well as the future caller in
> the error path of blk_register_queue().
>
> Also don't bother checking whether q is NULL, since it never is.
>
> Signed-off-by: Eric Biggers <redacted>
> ---
>   block/blk-sysfs.c | 3 +--
>   block/elevator.c  | 8 ++++----
>   2 files changed, 5 insertions(+), 6 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
```