Re: [PATCH 1/2] net: Remove net/ipx.h and uapi/linux/ipx.h header files

6 messages, 4 authors, 2021-09-22 · open the first message on its own page

Re: [PATCH 1/2] net: Remove net/ipx.h and uapi/linux/ipx.h header files

From: Eugene Syromiatnikov <hidden>
Date: 2021-09-01 16:52:26

Adding linux-audit, strace-devel, and linux-api to CC:.

On Wed, Sep 01, 2021 at 06:02:44PM +0200, Eugene Syromiatnikov wrote:
On Fri, Aug 13, 2021 at 08:08:02PM +0800, Cai Huoqing wrote:
quoted
commit <47595e32869f> ("<MAINTAINERS: Mark some staging directories>")
indicated the ipx network layer as obsolete in Jan 2018,
updated in the MAINTAINERS file

now, after being exposed for 3 years to refactoring, so to
delete uapi/linux/ipx.h and net/ipx.h header files for good.
additionally, there is no module that depends on ipx.h except
a broken staging driver(r8188eu)

Signed-off-by: Cai Huoqing <redacted>
This removal breaks audit[1] and potentially breaks strace[2][3], at least.

[1] https://github.com/linux-audit/audit-userspace/blob/ce58837d44b7d9fcb4e140c23f68e0c94d95ab6e/auparse/interpret.c#L48
[2] https://gitlab.com/strace/strace/-/blob/9fe63f42df8badd22fb7eef9c12fc07ed7106d6b/src/net.c#L34
[3] https://gitlab.com/strace/strace/-/blob/9fe63f42df8badd22fb7eef9c12fc07ed7106d6b/src/sockaddr.c#L30

Re: [PATCH 1/2] net: Remove net/ipx.h and uapi/linux/ipx.h header files

From: Steve Grubb <hidden>
Date: 2021-09-01 17:37:04

Hello,

Thanks for the heads up.

On Wednesday, September 1, 2021 12:52:02 PM EDT Eugene Syromiatnikov wrote:
Adding linux-audit, strace-devel, and linux-api to CC:.

On Wed, Sep 01, 2021 at 06:02:44PM +0200, Eugene Syromiatnikov wrote:
quoted
On Fri, Aug 13, 2021 at 08:08:02PM +0800, Cai Huoqing wrote:
quoted
commit <47595e32869f> ("<MAINTAINERS: Mark some staging directories>")
indicated the ipx network layer as obsolete in Jan 2018,
updated in the MAINTAINERS file

now, after being exposed for 3 years to refactoring, so to
delete uapi/linux/ipx.h and net/ipx.h header files for good.
additionally, there is no module that depends on ipx.h except
a broken staging driver(r8188eu)

Signed-off-by: Cai Huoqing <redacted>
This removal breaks audit[1] and potentially breaks strace[2][3], at
least.
I wouldn't say breaks so much as needs coordination with. :-)   If ipx is 
being dropped in its entirety, I can just make that part of the code 
conditional to the header existing.

-Steve
quoted
[1]
https://github.com/linux-audit/audit-userspace/blob/ce58837d44b7d9fcb4e1
40c23f68e0c94d95ab6e/auparse/interpret.c#L48 [2]
https://gitlab.com/strace/strace/-/blob/9fe63f42df8badd22fb7eef9c12fc07e
d7106d6b/src/net.c#L34 [3]
https://gitlab.com/strace/strace/-/blob/9fe63f42df8badd22fb7eef9c12fc07e
d7106d6b/src/sockaddr.c#L30


Re: [PATCH 1/2] net: Remove net/ipx.h and uapi/linux/ipx.h header files

From: Cai Huoqing <hidden>
Date: 2021-09-02 13:35:56

On 01 Sep 21 13:36:54, Steve Grubb wrote:
Hello,

Thanks for the heads up.

On Wednesday, September 1, 2021 12:52:02 PM EDT Eugene Syromiatnikov wrote:
quoted
Adding linux-audit, strace-devel, and linux-api to CC:.

On Wed, Sep 01, 2021 at 06:02:44PM +0200, Eugene Syromiatnikov wrote:
quoted
On Fri, Aug 13, 2021 at 08:08:02PM +0800, Cai Huoqing wrote:
quoted
commit <47595e32869f> ("<MAINTAINERS: Mark some staging directories>")
indicated the ipx network layer as obsolete in Jan 2018,
updated in the MAINTAINERS file

now, after being exposed for 3 years to refactoring, so to
delete uapi/linux/ipx.h and net/ipx.h header files for good.
additionally, there is no module that depends on ipx.h except
a broken staging driver(r8188eu)

Signed-off-by: Cai Huoqing <redacted>
This removal breaks audit[1] and potentially breaks strace[2][3], at
least.
I wouldn't say breaks so much as needs coordination with. :-)   If ipx is 
being dropped in its entirety, I can just make that part of the code 
conditional to the header existing.

-Steve
IPX is marked obsolete for serveral years. so remove it and the
dependency in linux tree.
I'm sorry to not thinking about linux-audit and strace.
Might you remove the dependency or make the part of the code.
Many thanks.

-Cai
quoted
quoted
[1]
https://github.com/linux-audit/audit-userspace/blob/ce58837d44b7d9fcb4e1
40c23f68e0c94d95ab6e/auparse/interpret.c#L48 [2]
https://gitlab.com/strace/strace/-/blob/9fe63f42df8badd22fb7eef9c12fc07e
d7106d6b/src/net.c#L34 [3]
https://gitlab.com/strace/strace/-/blob/9fe63f42df8badd22fb7eef9c12fc07e
d7106d6b/src/sockaddr.c#L30

Re: [PATCH 1/2] net: Remove net/ipx.h and uapi/linux/ipx.h header files

From: Eugene Syromiatnikov <hidden>
Date: 2021-09-02 16:25:58

On Thu, Sep 02, 2021 at 09:35:29PM +0800, Cai Huoqing wrote:
On 01 Sep 21 13:36:54, Steve Grubb wrote:
quoted
Hello,

Thanks for the heads up.

On Wednesday, September 1, 2021 12:52:02 PM EDT Eugene Syromiatnikov wrote:
quoted
Adding linux-audit, strace-devel, and linux-api to CC:.

On Wed, Sep 01, 2021 at 06:02:44PM +0200, Eugene Syromiatnikov wrote:
quoted
On Fri, Aug 13, 2021 at 08:08:02PM +0800, Cai Huoqing wrote:
quoted
commit <47595e32869f> ("<MAINTAINERS: Mark some staging directories>")
indicated the ipx network layer as obsolete in Jan 2018,
updated in the MAINTAINERS file

now, after being exposed for 3 years to refactoring, so to
delete uapi/linux/ipx.h and net/ipx.h header files for good.
additionally, there is no module that depends on ipx.h except
a broken staging driver(r8188eu)

Signed-off-by: Cai Huoqing <redacted>
This removal breaks audit[1] and potentially breaks strace[2][3], at
least.
I wouldn't say breaks so much as needs coordination with. :-)   If ipx is 
being dropped in its entirety, I can just make that part of the code 
conditional to the header existing.

-Steve
IPX is marked obsolete for serveral years. so remove it and the
dependency in linux tree.
I'm sorry to not thinking about linux-audit and strace.
Might you remove the dependency or make the part of the code.
Many thanks.
Unfortunately, that is not how UAPI works.  That change breaks building
of the existing code;  one cannot change already released versions
of either audit, strace, or any other userspace program that happens
to unconditionally include <linux/ipx.h> without any fallback (like
<netipx/ipx.h> provided by glibc).
-Cai
quoted
quoted
quoted
[1]
https://github.com/linux-audit/audit-userspace/blob/ce58837d44b7d9fcb4e1
40c23f68e0c94d95ab6e/auparse/interpret.c#L48 [2]
https://gitlab.com/strace/strace/-/blob/9fe63f42df8badd22fb7eef9c12fc07e
d7106d6b/src/net.c#L34 [3]
https://gitlab.com/strace/strace/-/blob/9fe63f42df8badd22fb7eef9c12fc07e
d7106d6b/src/sockaddr.c#L30


Re: [PATCH 1/2] net: Remove net/ipx.h and uapi/linux/ipx.h header files

From: Paul Cercueil <paul@crapouillou.net>
Date: 2021-09-22 17:02:27

Hi,
quoted
 IPX is marked obsolete for serveral years. so remove it and the
 dependency in linux tree.
 I'm sorry to not thinking about linux-audit and strace.
 Might you remove the dependency or make the part of the code.
 Many thanks.
Unfortunately, that is not how UAPI works.  That change breaks 
building
of the existing code;  one cannot change already released versions
of either audit, strace, or any other userspace program that happens
to unconditionally include <linux/ipx.h> without any fallback (like
<netipx/ipx.h> provided by glibc).
Also, the <netipx/ipx.h> fallback is only provided by glibc (and maybe 
uclibc?). With this patch, it is now impossible to compile even the 
very latest version of "strace" with a musl toolchain.

Cheers,
-Paul

Re: [PATCH 1/2] net: Remove net/ipx.h and uapi/linux/ipx.h header files

From: Steve Grubb <hidden>
Date: 2021-09-22 17:26:09

On Wednesday, September 22, 2021 1:01:58 PM EDT Paul Cercueil wrote:
quoted
quoted
IPX is marked obsolete for serveral years. so remove it and the
dependency in linux tree.
I'm sorry to not thinking about linux-audit and strace.
Might you remove the dependency or make the part of the code.
Many thanks.
Unfortunately, that is not how UAPI works.  That change breaks
building
of the existing code;  one cannot change already released versions
of either audit, strace, or any other userspace program that happens
to unconditionally include <linux/ipx.h> without any fallback (like
<netipx/ipx.h> provided by glibc).
Also, the <netipx/ipx.h> fallback is only provided by glibc (and maybe
uclibc?). With this patch, it is now impossible to compile even the
very latest version of "strace" with a musl toolchain.
I've made support for ipx optional in audit user space a couple weeks back. 
It's no longer a problem for us.

-Steve

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help