# Re: \[PATCH v3 14/14\] net/mlx4: Use irq\_update\_affinity\_hint

- From: Tariq Toukan \<hidden\>
- Date: 2021-07-14 11:19:34 
- List: linux-api
- Page: https://ratatoskr.run/linux-api/2021/07/1444021
- Thread: https://ratatoskr.run/linux-scsi/2021/07/1443407/t.md

```text


On 7/14/2021 12:15 AM, Nitesh Narayan Lal wrote:
> The driver uses irq_set_affinity_hint() to update the affinity_hint mask
> that is consumed by the userspace to distribute the interrupts. However,
> under the hood irq_set_affinity_hint() also applies the provided cpumask
> (if not NULL) as the affinity for the given interrupt which is an
> undocumented side effect.
>
> To remove this side effect irq_set_affinity_hint() has been marked
> as deprecated and new interfaces have been introduced. Hence, replace the
> irq_set_affinity_hint() with the new interface irq_update_affinity_hint()
> that only updates the affinity_hint pointer.
>
> Signed-off-by: Nitesh Narayan Lal <redacted>
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
> ---

Thanks for you patch.
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>

Tariq
```