# Re: \[Patch v4 1/3\] lib: Restrict cpumask\_local\_spread to houskeeping CPUs

- From: Thomas Gleixner \<hidden\>
- Date: 2021-01-28 16:03:54 
- List: linux-api
- Page: https://ratatoskr.run/linux-api/2021/01/6251070
- Thread: https://ratatoskr.run/linux-api/2020/06/6015293/t.md

```text
On Wed, Jan 27 2021 at 09:19, Marcelo Tosatti wrote:
> On Wed, Jan 27, 2021 at 11:57:16AM +0000, Robin Murphy wrote:
>> > +	hk_flags = HK_FLAG_DOMAIN | HK_FLAG_MANAGED_IRQ;
>> > +	mask = housekeeping_cpumask(hk_flags);
>> 
>> AFAICS, this generally resolves to something based on cpu_possible_mask
>> rather than cpu_online_mask as before, so could now potentially return an
>> offline CPU. Was that an intentional change?
>
> Robin,
>
> AFAICS online CPUs should be filtered.

The whole pile wants to be reverted. It's simply broken in several ways.

Thanks,

        tglx
```
