# Re: \[PATCH v11 3/8\] arch: move SA\_\* definitions to generic headers

- From: Peter Collingbourne \<hidden\>
- Date: 2020-10-09 15:49:39 
- List: linux-api
- Page: https://ratatoskr.run/linux-api/2020/10/8800047
- Thread: https://ratatoskr.run/linux-arm-kernel/2020/10/8800008/t.md

```text
On Fri, Oct 9, 2020 at 12:49 AM Geert Uytterhoeven [ref] wrote:
>
> On Fri, Oct 9, 2020 at 2:51 AM Peter Collingbourne [ref] wrote:
> > Most architectures with the exception of alpha, mips, parisc and
> > sparc use the same values for these flags. Move their definitions into
> > asm-generic/signal-defs.h and allow the architectures with non-standard
> > values to override them. Also, document the non-standard flag values
> > in order to make it easier to add new generic flags in the future.
> >
> > A consequence of this change is that on powerpc and x86, the constants'
> > values aside from SA_RESETHAND change signedness from unsigned
> > to signed. This is not expected to impact realistic use of these
> > constants. In particular the typical use of the constants where they
> > are or'ed together and assigned to sa_flags (or another int variable)
> > would not be affected.
> >
> > Signed-off-by: Peter Collingbourne <redacted>
> > Link: https://linux-review.googlesource.com/id/Ia3849f18b8009bf41faca374e701cdca36974528
>
> >  arch/m68k/include/uapi/asm/signal.h    | 24 -------------
>
> Please preserve my
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> given on v9 when posting new versions.

Sorry about that, I've applied your Acked-by locally and I'll include
it in future patches.

Peter
```
