# Re: \[net-next PATCH v3 2/7\] net: hsr: introduce common code for skb initialization

- From: Murali Karicheri \<hidden\>
- Date: 2020-07-20 13:20:51 
- List: linux-api
- Page: https://ratatoskr.run/linux-api/2020/07/6042245
- Thread: https://ratatoskr.run/netdev/2020/07/6040141/t.md

```text


On 7/17/20 9:56 PM, David Miller wrote:
> From: Murali Karicheri <redacted>
> Date: Fri, 17 Jul 2020 11:15:06 -0400
>
>> +static void send_hsr_supervision_frame(struct hsr_port *master,
>> +				       u8 type, u8 hsr_ver)
>> +{
>> +	struct sk_buff *skb;
>> +	struct hsr_tag *hsr_tag;
>> +	struct hsr_sup_tag *hsr_stag;
>> +	struct hsr_sup_payload *hsr_sp;
>> +	unsigned long irqflags;
>
> Reverse christmas tree please.
>
OK
-- 
Murali Karicheri
Texas Instruments
```