# Re: \[PATCH 1/3\] glibc: Perform rseq registration at C startup and thread creation (v21)

- List: linux-api
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-api/2020/06/6014010/t

## Re: \[PATCH 1/3\] glibc: Perform rseq registration at C startup and thread creation (v21)

- From: Florian Weimer \<hidden\>
- Date: 2020-06-24 19:24:33 
- Message: https://ratatoskr.run/linux-api/2020/06/6014010.md

```text
* Mathieu Desnoyers:

>> I think we should keep things simple on the glibc side for now and do
>> this changes to the kernel headers first.
>
> Just to be sure I understand what you mean by "keep things simple", do you
> recommend removing the following lines completely for now from sys/rseq.h ?
>
> /* Ensure the compiler supports rseq_align.  */
> __rseq_static_assert (__rseq_alignof (struct rseq_cs) >= 32, "alignment");
> __rseq_static_assert (__rseq_alignof (struct rseq) >= 32, "alignment");

Yes, that's what I meant.

Thanks,
Florian

```

## Re: \[PATCH 1/3\] glibc: Perform rseq registration at C startup and thread creation (v21)

- From: Mathieu Desnoyers \<mathieu.desnoyers@efficios.com\>
- Date: 2020-06-24 19:26:18 
- Message: https://ratatoskr.run/linux-api/2020/06/6014011.md

```text
----- On Jun 24, 2020, at 3:24 PM, Florian Weimer fweimer@redhat.com wrote:

> * Mathieu Desnoyers:
> 
>>> I think we should keep things simple on the glibc side for now and do
>>> this changes to the kernel headers first.
>>
>> Just to be sure I understand what you mean by "keep things simple", do you
>> recommend removing the following lines completely for now from sys/rseq.h ?
>>
>> /* Ensure the compiler supports rseq_align.  */
>> __rseq_static_assert (__rseq_alignof (struct rseq_cs) >= 32, "alignment");
>> __rseq_static_assert (__rseq_alignof (struct rseq) >= 32, "alignment");
> 
> Yes, that's what I meant.

Agreed, I queued this change for my next round.

Thanks,

Mathieu


-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
```