On Thu, Jan 16, 2020 at 11:20:08AM -0800, Eric Biggers wrote:
From: Eric Biggers <redacted>
Reserve flags for the hardware-wrapped keys feature which is being
worked on [1]. FSCRYPT_POLICY_FLAG_HW_WRAPPED_KEY will denote that the
encryption policy needs a hardware-wrapped key to be unlocked.
FSCRYPT_ADD_KEY_FLAG_HW_WRAPPED will denote that the key being added is
a hardware-wrapped key.
This reservation is tentative, and these codepoints may be reused if the
feature is not upstreamed.
NAK. While the feature itself sounds really useful we don't just
reserve format bits for code not upstream.
On Fri, Jan 17, 2020 at 12:12:46AM -0800, Christoph Hellwig wrote:
On Thu, Jan 16, 2020 at 11:20:08AM -0800, Eric Biggers wrote:
quoted
From: Eric Biggers <redacted>
Reserve flags for the hardware-wrapped keys feature which is being
worked on [1]. FSCRYPT_POLICY_FLAG_HW_WRAPPED_KEY will denote that the
encryption policy needs a hardware-wrapped key to be unlocked.
FSCRYPT_ADD_KEY_FLAG_HW_WRAPPED will denote that the key being added is
a hardware-wrapped key.
This reservation is tentative, and these codepoints may be reused if the
feature is not upstreamed.
NAK. While the feature itself sounds really useful we don't just
reserve format bits for code not upstream.
I disagree; saving a codepoint to avoid accidental collision of a
feature bit is a good and proper thing to do.
Reviewed-by: Theodore Ts'o <tytso@mit.edu>
- Ted
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
On Fri, Jan 17, 2020 at 11:40:54AM -0500, Theodore Y. Ts'o wrote:
On Fri, Jan 17, 2020 at 12:12:46AM -0800, Christoph Hellwig wrote:
quoted
On Thu, Jan 16, 2020 at 11:20:08AM -0800, Eric Biggers wrote:
quoted
From: Eric Biggers <redacted>
Reserve flags for the hardware-wrapped keys feature which is being
worked on [1]. FSCRYPT_POLICY_FLAG_HW_WRAPPED_KEY will denote that the
encryption policy needs a hardware-wrapped key to be unlocked.
FSCRYPT_ADD_KEY_FLAG_HW_WRAPPED will denote that the key being added is
a hardware-wrapped key.
This reservation is tentative, and these codepoints may be reused if the
feature is not upstreamed.
NAK. While the feature itself sounds really useful we don't just
reserve format bits for code not upstream.
I disagree; saving a codepoint to avoid accidental collision of a
feature bit is a good and proper thing to do.
Reviewed-by: Theodore Ts'o <tytso@mit.edu>
What kind of "deadline" do you have for that feature to then be merged?
I'm with Christoph here, we shouldn't be reserving bits for stuff not
in mergable state, what's the rush?
thansk,
greg k-h